'list' object has no attribute 'items'

[Weilong Chen]

Hi,I came accross this bug when I created a Multinode Job. It seem something wrong when I use default parameters.
:
ErrorMessage: 'list' object has no attribute 'items'
 Lava failed at action lava_test_shell with error:'list' object has no attribute 'items'
Traceback (most recent call last):
  File "/srv/lava/.cache/git-cache/exports/lava-dispatcher/2014.04-16-g5f3e076/lava_dispatcher/job.py", line 339, in run
  action.run(**params)
  File "/srv/lava/.cache/git-cache/exports/lava-dispatcher/2014.04-16-g5f3e076/lava_dispatcher/actions/lava_test_shell.py", line 697, in run
  testdef_repos, skip_install)
  File "/srv/lava/.cache/git-cache/exports/lava-dispatcher/2014.04-16-g5f3e076/lava_dispatcher/actions/lava_test_shell.py", line 925, in _configure_target
  testdef.copy_test(hdir, tdir)
  File "/srv/lava/.cache/git-cache/exports/lava-dispatcher/2014.04-16-g5f3e076/lava_dispatcher/actions/lava_test_shell.py", line 640, in copy_test
  URLTestDefinition.copy_test(self, hostdir, targetdir)
  File "/srv/lava/.cache/git-cache/exports/lava-dispatcher/2014.04-16-g5f3e076/lava_dispatcher/actions/lava_test_shell.py", line 562, in copy_test
  self._create_target_install(hostdir, targetdir)
  File "/srv/lava/.cache/git-cache/exports/lava-dispatcher/2014.04-16-g5f3e076/lava_dispatcher/actions/lava_test_shell.py", line 515, in _create_target_install
  self._inject_testdef_parameters(f)
  File "/srv/lava/.cache/git-cache/exports/lava-dispatcher/2014.04-16-g5f3e076/lava_dispatcher/actions/lava_test_shell.py", line 502, in _inject_testdef_parameters
  for def_param_name, def_param_value in self.testdef['params'].items():
 AttributeError: 'list' object has no attribute 'items'

The link is:
https://validation.linaro.org/scheduler/job/129800.1
https://validation.linaro.org/scheduler/job/129800.0

[Tyler Baker (tyler-baker)]

Hi Weilong,

You yaml does not take any parameters, yet you pass them in the JSON:

https://validation.linaro.org/scheduler/job/129800/multinode_definition

https://git.linaro.org/people/weilong.chen/lgp1.git/blob/HEAD:/openembedded/odp-generator-client.yaml

https://git.linaro.org/people/weilong.chen/lgp1.git/blob/HEAD:/openembedded/odp-generator-server.yaml

Here is an example of a YAML which defines parameters:

https://git.linaro.org/qa/test-definitions.git/blob/HEAD:/openembedded/netperf-client-multinode.yaml#l22

I agree though, that LAVA should produce a better error in this case. This will be fixed.

[Weilong Chen (weilong-chen)]

Fixed,
Thanks very much!