lava-test-runner calls distro-specific commands unconditionally
Bug #1154583 reported by
Marcin Juszkiewicz
This bug affects 2 people
| Affects | Status | Importance | Assigned to | Milestone | |
|---|---|---|---|---|---|
| LAVA Dispatcher |
Fix Released
|
High
|
Antonio Terceiro | ||
Bug Description
There is lava-test-runner for Ubuntu and one for Android but there is no version for blackbox images - like OpenEmbedded ones for example.
So I used Ubuntu one. It has few assumptions which may be not fulfilled by OE:
<LAVA_TEST_RUNNER>: started
<LAVA_TEST_RUNNER>: looking for installation work in /lava/lava-
<LAVA_TEST_RUNNER>: save hardware/software context info...
cat: can't open '/etc/lsb-release': No such file or directory
/lava/bin/
full log: http://
Someone can say "live with it" but I would prefer to not have non-related errors in log just because there is no proper tool
Related branches
lp:~terceiro/lava-dispatcher/lava-test-shell-oe
- Senthil Kumaran S: Approve
-
Diff: 46 lines (+21/-1)1 file modifiedlava_test_shell/lava-test-runner-ubuntu (+21/-1)
Revision history for this message
| Antonio Terceiro (terceiro) wrote | #1 |
| Changed in lava-dispatcher: | |
| importance: | Undecided → High |
| status: | New → Confirmed |
| assignee: | nobody → Antonio Terceiro (terceiro) |
| milestone: | none → 2013.03 |
Revision history for this message
| Antonio Terceiro (terceiro) wrote | #2 |
| Changed in lava-dispatcher: | |
| status: | Confirmed → In Progress |
| summary: |
- There is no blackbox version of lava-test-runner + lava-test-runner calls distro-specific commands unconditionally |
| Changed in lava-dispatcher: | |
| status: | In Progress → Fix Committed |
| no longer affects: | linaro-oe |
| Changed in lava-dispatcher: | |
| status: | Fix Committed → Fix Released |
To post a comment you must log in.
Yes - having distro-dependent code there is wrong and we should fix it.
Or, at least, we should check for the availability of the stuff we need before actually calling them.