lava_test_shell's testdef_repos assumes flat repo layout
Affects | Status | Importance | Assigned to | Milestone | |
---|---|---|---|---|---|
LAVA Dispatcher |
Fix Released
|
Medium
|
Michael Hudson-Doyle |
Bug Description
I'm trying new testdef_repos functionality with:
{
"command": "lava_test_shell",
{
}
],
}
},
I get (with added debug output):
Traceback (most recent call last):
File "/srv/lava/
lava.
File "/srv/lava/
raise SystemExit(
File "/srv/lava/
return command.invoke()
File "/srv/lava/
shutil.copy2( tmp0wcFLd/
shutil.copy2( tmp0wcFLd/
shutil.copy2( tmp0wcFLd/
Lava failed at action lava_test_shell with error:[Errno 21] Is a directory: 'tmp0wcFLd/
So, there're 2 issues: 1) testdef_repos doesn't expect the repo to contain any subdirectories, and bails out if it does, which is definitely a bug. And 2) it's not necessarily does what user expect - in this particular case, it's a repo for standalone project, and lava testdef are just part of it, in one of subdirs. Just copying top-level files doesn't help much, and testdef_repos can't really know which files of a repo a user may need. Assuming it's too cumbersome to list all needed files explicitly, it would make sense to just copy over entire repo checkout recursively, which would solve both issues.
Related branches
- Linaro Validation Team: Pending requested
-
Diff: 95 lines (+17/-8)5 files modifiedlava_dispatcher/actions/lava_test_shell.py (+2/-2)
lava_dispatcher/lava_test_shell.py (+1/-1)
lava_test_shell/lava-test-case (+4/-3)
lava_test_shell/lava-test-runner-android (+5/-1)
lava_test_shell/lava-test-runner-ubuntu (+5/-1)
Changed in lava-dispatcher: | |
importance: | Undecided → Critical |
importance: | Critical → Medium |
milestone: | none → 2012.12 |
assignee: | nobody → Senthil Kumaran S (stylesen) |
Changed in lava-dispatcher: | |
assignee: | Senthil Kumaran S (stylesen) → Michael Hudson-Doyle (mwhudson) |
Changed in lava-dispatcher: | |
status: | New → Fix Committed |
Changed in lava-dispatcher: | |
status: | Fix Committed → Fix Released |
I have a fix for this in another branch. Will cherry pick it to trunk
today.