get_token_and_login tries to do a desktop integration but doesn't send the right values

[Leonard Richardson]

The deprecated method get_token_and_login tries to ask for a desktop integration token, but it doesn't give Launchpad the necessary information. The user is taken to a page and given an exception:

Unauthorized: Consumer "foo" asked for desktop integration, but didn't say what kind of desktop it is, or name the computer being integrated.<br />

The URL looks like this: https://staging.launchpad.net/+authorize-token?oauth_token=fooallow_permission=DESKTOP_INTEGRATION

[Robert Collins (lifeless)]

Is this a regression, or something that folk running old code will experience? does that method emit a deprecation warning?

[Robert Collins (lifeless)]

triaging to low because its a deprecated method; feel free to correct if thats wrong.

[Leonard Richardson (leonardr)]

It's a method that I just deprecated in the most recent version, and I also broke it in that version, so I think it's important to fix it and give anyone using it some breathing room.

[Leonard Richardson (leonardr)]

To answer your first question, anyone who uses old code without a cached token will get this problem. The main case where I can think of this happening is someone who copies old code onto another computer and runs it there.