possible to land broken code in launchpadlib

[Leonard Richardson]

The launchpadlib doctests can only be run in the context of a Launchpad instance. But the Launchpad test suite _only_ runs the launchpadlib doctests, not the unit tests. It's possible for a full EC2 test to succeed with a launchpadlib that has broken unit tests. I know because it happened to me and I landed broken code. I thought I was safe because I forgot I needed to run two sets of tests.

If Launchpad's test suite ran the launchpadlib unit tests as well as the doctests, this problem would be avoided. You might say that Launchpad shouldn't be in the business of running other apps' tests, but Launchpad already runs launchpadlib's doctests, so it's not much of a slippery slope. I think the Launchpad-launchpadlib relationship is close enough to justify making this change in the name of launchpadlib quality.

[Robert Collins (lifeless)]

Alternatively, launchpadlib could use e.g. qastaging or a local LP instance to run its tests, and document that as a dependency.