login_with should not popup browser under sudo

Bug #1825014 reported by Dan Streetman on 2019-04-16
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
launchpadlib
High
Dan Streetman

Bug Description

When running under sudo, popping up a new browser as the root user is almost certainly not a good thing to do. In fact, chromium/chrome refuses to do so, and prints:
[162589:162589:0212/125610.703398:ERROR:zygote_host_impl_linux.cc(89)] Running as root without --no-sandbox is not supported. See https://crbug.com/638180.

which (if running on graphical system) results in a pop-up showing the error:
"Failed to execute default Web Browser."
"Input/Output error."

Additionally, similar to bug 1862948, opening a browser under sudo will save any cookies or other browser data as the sudo'ed user (i.e. root, usually) instead of the calling user. This is unlikely to be what the user actually wants, and can be confusing on any system with shared root access, where user "B" may have a browser pop-up automatically log them in as user "A" and/or prefill the wrong login information.

Related branches

Dan Streetman (ddstreet) on 2020-02-12
description: updated
Dan Streetman (ddstreet) on 2020-02-22
summary: - login_with forces opening of browser
+ login_with should not popup browser under sudo
description: updated
description: updated
Colin Watson (cjwatson) wrote :

Fixed in launchpadlib 1.10.11. Thanks for the contribution.

Changed in launchpadlib:
assignee: nobody → Dan Streetman (ddstreet)
importance: Undecided → High
milestone: none → 1.10.11
status: New → Fix Released
To post a comment you must log in.
This report contains Public information  Edit
Everyone can see this information.

Other bug subscribers