Declares that it depends on testresources at the python level, but the package doesn't depend on it

Bug #1019700 reported by James Westby
16
This bug affects 3 people
Affects Status Importance Assigned to Milestone
launchpadlib
Fix Released
Low
Colin Watson
python-launchpadlib (Ubuntu)
Fix Released
Low
Unassigned

Bug Description

launchpadlib has testresources listed in its requires.txt, though it is only a test dependency.

The package in Ubuntu doesn't depend on python-testresources.

If you try and use pkg_resources in any project that depends on launchpadlib you
get errors if python-testresources isn't installed.

The packaging could add the dependency, but it's only needed to run launchpadlib's
test suite.

launchpadlib could move testresources to be a test dependency (either test_requires
or whatever the spelling it, or an extra_requires for [test] or however that is done.)

In the meantime the workaround is to install python-testresources if you need
to use pkg_resources in a project that depends on launchpadlib.

Thanks,

James

Tags: launchpadlib

Related branches

Revision history for this message
Daniel Letzeisen (dtl131) wrote :

python-testresources is only listed as "Suggests"

Changed in python-launchpadlib (Ubuntu):
status: New → Confirmed
Changed in python-launchpadlib (Ubuntu Precise):
status: New → Confirmed
Changed in launchpadlib:
status: New → Triaged
importance: Undecided → Low
tags: added: launchpadlib
Changed in python-launchpadlib (Ubuntu Precise):
importance: Undecided → Low
Changed in python-launchpadlib (Ubuntu):
importance: Undecided → Low
Revision history for this message
S Prasanth (prasanth-s-cmi) wrote :

Still persists in the python3-launchpadlib 1.10.13 package in Ubuntu 20.04.

Not sure if the right solution would be to
A) move `testresources` from `install_requires` to `tests_require` in the setup.py file (https://bazaar.launchpad.net/~lazr-developers/launchpadlib/trunk/view/head:/setup.py), or
B) make `python3-testresources` a dependency of the `python3-launchpadlib` package.

Option (A) would make more sense to me. Cheers!

Revision history for this message
Sorin Sbarnea (ssbarnea) wrote :

After 8 years I would not be surprised everyone lost hope of seeing it fixed.

The fact that its codebase is hosted on bazaar instead of a git.* server which accepts fixes does clearly not invite to external contributions, even as simple as this ones.

I would argue that it would be easier to fork it to github and to make it easier to maintain but that is not my call.

For the moment I see the library as dangerous dependency to have dues to it maintenance status.

Anyone developing a client that relies on launchpadlib risks a lot, especially if this client is supposed to be a multi-platform one as I see no CI setup for it.

no longer affects: python-launchpadlib (Ubuntu Precise)
Colin Watson (cjwatson)
Changed in launchpadlib:
status: Triaged → Fix Committed
assignee: nobody → Colin Watson (cjwatson)
Revision history for this message
Colin Watson (cjwatson) wrote :

1.10.15 (2021-10-27)
====================
- Move dependencies of launchpadlib.testing to a new ``testing`` extra.
  [bug=1019700]
- Stop excluding MANIFEST.in from the sdist.
- Declare support for Python 3.9 and 3.10.
- Move code hosting to git (https://code.launchpad.net/launchpadlib).

Changed in launchpadlib:
milestone: none → 1.10.15
status: Fix Committed → Fix Released
Revision history for this message
Colin Watson (cjwatson) wrote :

The fix is packaged in Ubuntu >= jammy now too.

Changed in python-launchpadlib (Ubuntu):
status: Confirmed → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.