test_openFileInNonDirectory has UncleanReactorError

[Gary Poster]

Even after the fix for bug 963463, I still see the following test failure intermittently on parallel runs

======================================================================
ERROR: lp.codehosting.tests.test_sftp.TestSFTPFile.test_openFileInNonDirectory
----------------------------------------------------------------------
Traceback (most recent call last):
_StringException: Empty attachments:
  log
  twisted-log

Traceback (most recent call last):
  File "/var/lib/buildbot/dependencies/eggs/testtools-0.9.14-py2.6.egg/testtools/deferredruntest.py", line 199, in _log_user_exception
    raise e
UncleanReactorError: The reactor still thinks it needs to do things. Close all connections, kill all processes and make sure all delayed calls have either fired or been cancelled:
  <DelayedCall 0x13d9878c [-3.51260399818s] called=0 cancelled=1>

[Gary Poster (gary)]

Also

======================================================================
ERROR: lp.codehosting.tests.test_sftp.TestSFTPServer.test_openDirectoryMemory
----------------------------------------------------------------------
Traceback (most recent call last):
_StringException: Empty attachments:
  log
  twisted-log

Traceback (most recent call last):
  File "/var/lib/buildbot/dependencies/eggs/testtools-0.9.14-py2.6.egg/testtools/deferredruntest.py", line 199, in _log_user_exception
    raise e
UncleanReactorError: The reactor still thinks it needs to do things. Close all connections, kill all processes and make sure all delayed calls have either fired or been cancelled:
  <DelayedCall 0x1101b16c [-2.24071097374s] called=0 cancelled=1>

[Gary Poster (gary)]

Another

======================================================================
ERROR: lp.codehosting.vfs.tests.test_branchfsclient.TestBranchFileSystemClient.test_translatePath_adds_to_cache
----------------------------------------------------------------------
Traceback (most recent call last):
_StringException: Empty attachments:
  twisted-log

Traceback (most recent call last):
  File "/var/lib/buildbot/dependencies/eggs/testtools-0.9.14-py2.6.egg/testtools/deferredruntest.py", line 199, in _log_user_exception
    raise e
UncleanReactorError: The reactor still thinks it needs to do things. Close all connections, kill all processes and make sure all delayed calls have either fired or been cancelled:
  <DelayedCall 0xd1f1eac [-3.7676589489s] called=0 cancelled=1>

[Gary Poster (gary)]

I can't dupe these in isolation, but I assume that these will prove to be more test isolation errors like those in bug 924378, in which the problem is in some test run prior to these.

[Gary Poster (gary)]

Also lp.codehosting.tests.test_sftp.TestSFTPServer.test_translateDirectoryNotEmpty

[Launchpad QA Bot (lpqabot)]

Fixed in stable r15124 (http://bazaar.launchpad.net/~launchpad-pqm/launchpad/stable/revision/15124) by a commit, but not testable.