Root page breaks when blog.launchpad.net is down
Bug #939055 reported by
Robert Collins
This bug affects 4 people
Affects | Status | Importance | Assigned to | Milestone | |
---|---|---|---|---|---|
Launchpad itself |
Triaged
|
High
|
Unassigned |
Bug Description
Front page blog feed updates are done in-line with requests.
This fails hard when blog.launchpad.net is down.
It would be better to keep serving old content than fail; we need to either set a low timeout, or obtain the content asynchronously, and keep it cached in memcache indefinitely.
(Nagios alerted on all of LP when blog.l.n was down today)
Related branches
lp:~gz/launchpad/root_blog_feature_flag_939055
- Benji York (community): Approve (code)
-
Diff: 194 lines (+90/-8)5 files modifiedlib/lp/app/browser/root.py (+9/-0)
lib/lp/app/browser/tests/test_launchpadroot.py (+64/-0)
lib/lp/app/stories/launchpad-root/front-pages.txt (+4/-2)
lib/lp/app/templates/root-index.pt (+7/-6)
lib/lp/services/features/flags.py (+6/-0)
Changed in launchpad: | |
assignee: | John A Meinel (jameinel) → Martin Packman (gz) |
Changed in launchpad: | |
status: | Triaged → In Progress |
tags: |
added: qa-ok removed: qa-needstesting |
description: | updated |
summary: |
- front page blog feed updates are done in-line with requests + Root page breaks when blog.launchpad.net is down |
Changed in launchpad: | |
status: | Fix Committed → Fix Released |
tags: | removed: escalated |
To post a comment you must log in.
I'm going to escalate this, we need a fix in place for mid august. We need one of:
- inject it into memcache asynchronously,
- handle blog.l.n being gone very gracefully
- allow it to be disabled via a featureflag
I suspect a featureflag is easier for now, which won't fully fix this bug but will give us the ability to do downtime on blog.l.n.