setuplxc scrambles your bzr whoami

[Martin Pool]

setuplxc has:

        # Set up bzr and Launchpad authentication.
        subprocess.call([
            'bzr', 'whoami', '"{} <{}>"'.format(fullname, email)])

this means every time you run it, your username gets re-quoted:

 Martin Pool <email address hidden>
 "Martin Pool <email address hidden>"

etc.

The quotes are unnecessary as this isn't being run through a shell.

Also, it looks like this is being done to the host home directory.

If home is bind mounted, this isn't necessary, as the configuration should already be correct. Otherwise, this needs to be sent in to the guest.

[Martin Pool (mbp)]

critical on the grounds this breaks the bzr setup of the person trying to run it; rerate it as you will

I _think_ it's enough just to cut out the lines that do that, but I don't know

[Robert Collins (lifeless)]

the parallel tester shouldn't be doing any commits, so there is no
need for this at all AFAICT.

[Martin Pool (mbp)]

On 22 February 2012 06:36, Robert Collins <email address hidden> wrote:
> the parallel tester shouldn't be doing any commits, so there is no
> need for this at all AFAICT.

I don't see why it's there either.

I think lxc is combining some stuff for "set up my host machine to run
lp lxcs" and "actually start an lxc". I think it would be cleaner if
they were separate, easier to audit if the host changes were
reasonable, and not a burden on the user. I think the point of this
is that on a new eg ec2 vm, you might want to set your identity on the
host(?) but that obviously isn't good on a local development machine.

--
Martin

[Benji York (benji)]

The overtly bad behavior of breaking whois info by adding quotes was fixed some time ago. I don't know enough at this time to say whether or not the code should be removed alltogether.