Update branch to use information_visibility_policy
Bug #933768 reported by
Curtis Hovey
This bug affects 1 person
Affects | Status | Importance | Assigned to | Milestone | |
---|---|---|---|---|---|
Launchpad itself |
Fix Released
|
High
|
Steve Kowalik |
Bug Description
Once the schema is available to access information_
Related branches
lp:~stevenk/launchpad/branch-information_type-model
- Ian Booth (community): Approve
- Diff: 0 lines
lp:~stevenk/launchpad/branch-information_type-garbo
- William Grant (community): Approve (code)
-
Diff: 100 lines (+51/-0)2 files modifiedlib/lp/scripts/garbo.py (+28/-0)
lib/lp/scripts/tests/test_garbo.py (+23/-0)
lp:~stevenk/launchpad/db-branch-information_type-index
- Stuart Bishop (community): Approve (db)
- Robert Collins: Pending (db) requested
-
Diff: 12 lines (+8/-0)1 file modifieddatabase/schema/patch-2209-12-4.sql (+8/-0)
lp:~stevenk/launchpad/drop-branch-information_type-garbo
- Steve Kowalik (community): Approve (code)
-
Diff: 101 lines (+0/-52)2 files modifiedlib/lp/scripts/garbo.py (+0/-29)
lib/lp/scripts/tests/test_garbo.py (+0/-23)
lp:~stevenk/launchpad/db-branch-information_type-not-null
- Stuart Bishop (community): Approve (db)
- Robert Collins: Pending (db) requested
-
Diff: 174 lines (+72/-64)3 files modifieddatabase/sampledata/current-dev.sql (+32/-32)
database/sampledata/current.sql (+32/-32)
database/schema/patch-2209-12-5.sql (+8/-0)
lp:~stevenk/launchpad/branch-use-information_type
- William Grant (community): Approve (code)
-
Diff: 355 lines (+102/-34)9 files modifiedlib/lp/code/browser/tests/test_branch.py (+6/-3)
lib/lp/code/browser/tests/test_branchmergeproposal.py (+2/-1)
lib/lp/code/errors.py (+5/-0)
lib/lp/code/model/branch.py (+32/-11)
lib/lp/code/model/tests/test_branch.py (+28/-2)
lib/lp/code/model/tests/test_branchmergeproposal.py (+3/-2)
lib/lp/code/model/tests/test_branchvisibility.py (+4/-7)
lib/lp/code/xmlrpc/tests/test_branch.py (+4/-2)
lib/lp/testing/factory.py (+18/-6)
lp:~stevenk/launchpad/branch-use-information_type-redux
- William Grant (community): Approve (code)
-
Diff: 603 lines (+135/-100)18 files modifiedlib/lp/app/browser/tests/test_launchpad.py (+6/-3)
lib/lp/code/browser/tests/test_branch.py (+6/-3)
lib/lp/code/browser/tests/test_branchmergeproposal.py (+2/-1)
lib/lp/code/errors.py (+5/-0)
lib/lp/code/interfaces/branch.py (+7/-4)
lib/lp/code/model/branch.py (+35/-12)
lib/lp/code/model/tests/test_branch.py (+29/-3)
lib/lp/code/model/tests/test_branchlookup.py (+2/-1)
lib/lp/code/model/tests/test_branchmergeproposal.py (+4/-3)
lib/lp/code/model/tests/test_branchvisibility.py (+4/-7)
lib/lp/code/model/tests/test_sourcepackagerecipe.py (+3/-1)
lib/lp/code/model/tests/test_sourcepackagerecipebuild.py (+4/-2)
lib/lp/code/stories/branches/xx-branch-edit-privacy.txt (+0/-33)
lib/lp/code/stories/branches/xx-branch-index.txt (+0/-15)
lib/lp/code/xmlrpc/tests/test_branch.py (+4/-2)
lib/lp/registry/stories/product/xx-product-development-focus.txt (+6/-2)
lib/lp/testing/factory.py (+14/-6)
lib/lp/translations/tests/test_translationtemplatesbuildjob.py (+4/-2)
lp:~stevenk/launchpad/branch-information_type-ui
- William Grant (community): Approve (code)
-
Diff: 505 lines (+224/-79)7 files modifiedlib/lp/app/browser/informationtype.py (+61/-0)
lib/lp/bugs/browser/bug.py (+2/-42)
lib/lp/code/browser/branch.py (+65/-32)
lib/lp/code/browser/configure.zcml (+3/-5)
lib/lp/code/browser/tests/test_branch.py (+81/-0)
lib/lp/code/templates/branch-portlet-privacy.pt (+6/-0)
lib/lp/services/features/flags.py (+6/-0)
lp:~stevenk/launchpad/branch-information_type-factory
- Ian Booth (community): Approve
-
Diff: 1850 lines (+334/-186)38 files modifiedlib/lp/app/browser/tests/test_launchpad.py (+6/-3)
lib/lp/bugs/model/tests/test_bug.py (+2/-1)
lib/lp/bugs/tests/test_bugchanges.py (+4/-2)
lib/lp/code/browser/tests/test_bazaar.py (+8/-4)
lib/lp/code/browser/tests/test_branchmergeproposal.py (+5/-3)
lib/lp/code/browser/tests/test_branchmergeproposallisting.py (+4/-2)
lib/lp/code/browser/tests/test_branchmergequeuelisting.py (+5/-3)
lib/lp/code/browser/tests/test_product.py (+6/-5)
lib/lp/code/browser/tests/test_sourcepackagerecipe.py (+7/-3)
lib/lp/code/model/tests/test_branch.py (+22/-13)
lib/lp/code/model/tests/test_branchcollection.py (+13/-11)
lib/lp/code/model/tests/test_branchlookup.py (+13/-7)
lib/lp/code/model/tests/test_branchmergeproposal.py (+2/-1)
lib/lp/code/model/tests/test_branchmergequeuecollection.py (+15/-11)
lib/lp/code/model/tests/test_branchpuller.py (+4/-2)
lib/lp/code/model/tests/test_branchset.py (+6/-3)
lib/lp/code/model/tests/test_branchtarget.py (+6/-3)
lib/lp/code/model/tests/test_branchvisibility.py (+15/-5)
lib/lp/code/model/tests/test_revision.py (+12/-7)
lib/lp/code/model/tests/test_sourcepackagerecipe.py (+7/-4)
lib/lp/code/stories/branches/xx-private-branch-listings.txt (+2/-1)
lib/lp/code/tests/helpers.py (+8/-2)
lib/lp/code/tests/test_branch.py (+26/-13)
lib/lp/code/tests/test_branch_webservice.py (+3/-1)
lib/lp/code/xmlrpc/tests/test_branch.py (+6/-3)
lib/lp/code/xmlrpc/tests/test_codehosting.py (+22/-9)
lib/lp/codehosting/codeimport/tests/test_worker.py (+5/-3)
lib/lp/codehosting/inmemory.py (+18/-11)
lib/lp/codehosting/puller/tests/test_acceptance.py (+7/-2)
lib/lp/codehosting/tests/test_rewrite.py (+9/-6)
lib/lp/registry/browser/tests/test_pillar_sharing.py (+2/-1)
lib/lp/registry/services/tests/test_sharingservice.py (+4/-2)
lib/lp/registry/tests/test_distro_webservice.py (+4/-2)
lib/lp/registry/tests/test_private_team_visibility.py (+16/-3)
lib/lp/registry/tests/test_productjob.py (+12/-10)
lib/lp/testing/factory.py (+17/-18)
lib/lp/translations/browser/tests/test_productserieslanguage_views.py (+8/-5)
lib/lp/translations/stories/productseries/xx-productseries-translations.txt (+3/-1)
lp:~stevenk/launchpad/branch-subscribe-aag
- Ian Booth (community): Approve
-
Diff: 777 lines (+243/-71)21 files modifiedlib/lp/app/errors.py (+7/-1)
lib/lp/app/tests/test_errors.py (+33/-0)
lib/lp/bugs/browser/bugsubscription.py (+1/-1)
lib/lp/bugs/errors.py (+1/-7)
lib/lp/bugs/model/bug.py (+2/-2)
lib/lp/bugs/tests/test_errors.py (+1/-7)
lib/lp/code/browser/branchsubscription.py (+13/-9)
lib/lp/code/browser/tests/test_branch.py (+7/-4)
lib/lp/code/browser/tests/test_branchlisting.py (+1/-1)
lib/lp/code/browser/tests/test_branchmergeproposal.py (+6/-2)
lib/lp/code/browser/tests/test_branchsubscription.py (+30/-2)
lib/lp/code/model/branch.py (+20/-5)
lib/lp/code/model/branchmergeproposal.py (+16/-3)
lib/lp/code/model/tests/test_branch.py (+7/-2)
lib/lp/code/model/tests/test_branchcollection.py (+4/-1)
lib/lp/code/model/tests/test_branchmergeproposal.py (+40/-2)
lib/lp/code/model/tests/test_branchnamespace.py (+15/-17)
lib/lp/code/model/tests/test_branchsubscription.py (+30/-2)
lib/lp/code/model/tests/test_branchvisibility.py (+4/-1)
lib/lp/registry/tests/test_distro_webservice.py (+4/-1)
lib/lp/testing/factory.py (+1/-1)
lp:~stevenk/launchpad/fix-branch-subscribe-open-team
- Ian Booth (community): Approve
- Launchpad code reviewers from Canonical: Pending (code) requested
- Diff: 0 lines
lp:~stevenk/launchpad/branch-privacy-properties
- William Grant (community): Approve (code)
-
Diff: 69 lines (+16/-7)2 files modifiedlib/lp/code/model/branch.py (+15/-6)
lib/lp/code/model/branchnamespace.py (+1/-1)
lp:~stevenk/launchpad/destroy-branch-privacy
- William Grant (community): Approve (code)
-
Diff: 295 lines (+7/-248)3 files modifiedlib/lp/code/model/branch.py (+0/-18)
lib/lp/code/model/branchnamespace.py (+7/-7)
lib/lp/code/model/tests/test_branch_privacy_triggers.py (+0/-223)
lp:~stevenk/launchpad/db-branch-new-access-policy
- Stuart Bishop (community): Approve (db)
- Robert Collins: Pending (db) requested
-
Diff: 389 lines (+262/-78)5 files modifieddatabase/sampledata/current-dev.sql (+38/-38)
database/sampledata/current.sql (+38/-38)
database/schema/comments.sql (+0/-2)
database/schema/patch-2209-16-6.sql (+146/-0)
lib/lp/code/tests/test_branch_access_policy_triggers.py (+40/-0)
lp:~stevenk/launchpad/populate-branch-ap
- William Grant (community): Approve (code)
-
Diff: 110 lines (+50/-0)3 files modifieddatabase/schema/security.cfg (+2/-0)
lib/lp/scripts/garbo.py (+22/-0)
lib/lp/scripts/tests/test_garbo.py (+26/-0)
lp:~stevenk/launchpad/destroy-old-privacy-ui
- Ian Booth (community): Approve
-
Diff: 1619 lines (+126/-616)33 files modifieddatabase/sampledata/current-dev.sql (+0/-1)
lib/lp/app/browser/informationtype.py (+0/-6)
lib/lp/bugs/browser/bug.py (+8/-105)
lib/lp/bugs/browser/bugtarget.py (+18/-58)
lib/lp/bugs/browser/bugtask.py (+3/-7)
lib/lp/bugs/browser/tests/bugtarget-filebug-views.txt (+4/-6)
lib/lp/bugs/browser/tests/test_bug_views.py (+8/-65)
lib/lp/bugs/browser/tests/test_bugtarget_filebug.py (+16/-26)
lib/lp/bugs/browser/tests/test_bugtask.py (+3/-5)
lib/lp/bugs/javascript/bugtask_index.js (+1/-43)
lib/lp/bugs/javascript/filebug.js (+1/-20)
lib/lp/bugs/javascript/information_type_choice.js (+1/-6)
lib/lp/bugs/javascript/tests/test_filebug.js (+0/-5)
lib/lp/bugs/javascript/tests/test_information_type_choice.js (+0/-1)
lib/lp/bugs/stories/bug-also-affects/xx-also-affects-upstream-private-bug.txt (+1/-6)
lib/lp/bugs/stories/bug-privacy/xx-bug-privacy.txt (+4/-20)
lib/lp/bugs/stories/bug-privacy/xx-presenting-private-bugs.txt (+6/-8)
lib/lp/bugs/stories/bugs/xx-bug-activity.txt (+6/-19)
lib/lp/bugs/stories/bugs/xx-duplicate-of-private-bug.txt (+2/-3)
lib/lp/bugs/stories/bugtracker/xx-bugtracker-remote-bug.txt (+4/-10)
lib/lp/bugs/stories/bugtracker/xx-bugtracker.txt (+3/-4)
lib/lp/bugs/stories/initial-bug-contacts/xx-initial-bug-contacts.txt (+2/-4)
lib/lp/bugs/stories/upstream-bugprivacy/xx-upstream-bug-privacy.txt (+2/-16)
lib/lp/bugs/templates/bug-portlet-privacy.pt (+0/-22)
lib/lp/bugs/templates/bugtarget-filebug-guidelines.pt (+0/-39)
lib/lp/code/browser/branch.py (+3/-34)
lib/lp/code/browser/tests/test_branch.py (+14/-24)
lib/lp/code/stories/branches/xx-branch-edit-privacy.txt (+10/-20)
lib/lp/code/stories/branches/xx-branch-index.txt (+1/-1)
lib/lp/code/stories/branches/xx-branch-listings.txt (+2/-3)
lib/lp/code/stories/branches/xx-bug-branch-links.txt (+3/-4)
lib/lp/code/templates/branch-portlet-privacy.pt (+0/-12)
lib/lp/services/features/flags.py (+0/-13)
tags: | added: information-type |
Changed in launchpad: | |
status: | Fix Committed → In Progress |
tags: |
added: qa-ok removed: qa-needstesting |
tags: |
added: qa-untestable removed: qa-needstesting |
tags: |
added: qa-ok removed: qa-needstesting |
Changed in launchpad: | |
status: | Fix Committed → In Progress |
tags: |
added: qa-untestable removed: qa-needstesting |
tags: |
added: bad-commit-15289 qa-bad removed: qa-untestable |
tags: |
added: qa-ok removed: qa-needstesting |
tags: |
added: qa-ok removed: qa-needstesting |
tags: |
added: qa-untestable removed: qa-needstesting |
Changed in launchpad: | |
status: | In Progress → Fix Released |
Changed in launchpad: | |
status: | Fix Released → In Progress |
tags: |
added: qa-ok removed: qa-needstesting |
tags: |
added: qa-ok removed: qa-needstesting |
tags: |
added: qa-ok removed: qa-needstesting |
tags: |
added: qa-ok removed: qa-needstesting |
tags: |
added: qa-ok removed: qa-needstesting |
tags: | added: privacy |
tags: |
added: qa-ok removed: qa-needstesting |
Changed in launchpad: | |
status: | Fix Committed → Fix Released |
To post a comment you must log in.
r11569 in db-stable (http:// bazaar. launchpad. net/~launchpad- pqm/launchpad/ db-stable/ revision/ 11569) is part of this bug's fix.