| 2012-01-19 15:53:39 |
Curtis Hovey |
bug |
|
|
added bug |
| 2012-01-19 16:40:13 |
Curtis Hovey |
description |
I tried to delete a team that had private branches in projects with branch visibility rules. Merge transfers artefacts that must have owners, such as as branches to ~registry. Merge oopses because ~registry does not have a policy for the project. Lp might want to ask the user to provide another team to transfer the branches too. Maybe Lp should explain the user might want to do a merge with a new team instead.
OOPS-b2214aa38cea8f74df0b9d79b02ef765
BranchCreationForbidden: You cannot create branches in "~registry/<PROJECT>"
Traceback (most recent call last):
Module lp.services.job.runner, line 267, in runJobHandleError
self.runJob(job)
Module lp.services.job.runner, line 225, in runJob
job.run()
Module lp.registry.model.persontransferjob, line 427, in run
reviewer=self.reviewer)
Module lp.registry.model.person, line 4063, in delete
return self._merge(from_person, to_person, reviewer, True)
Module lp.registry.model.person, line 4165, in _merge
self._mergeBranches(from_person, to_person)
Module lp.registry.model.person, line 3611, in _mergeBranches
removeSecurityProxy(branch).setOwner(to_person, to_person)
Module lp.code.model.branch, line 220, in setOwner
new_namespace.moveBranch(self, user, rename_if_necessary=True)
Module lp.code.model.branchnamespace, line 199, in moveBranch
self.validateMove(branch, mover, new_name)
Module lp.code.model.branchnamespace, line 186, in validateMove
self.validateRegistrant(mover)
Module lp.code.model.branchnamespace, line 166, in validateRegistrant
'You cannot create branches in "%s"' % self.name)
BranchCreationForbidden: You cannot create branches in "~registry/<PROJECT>" |
I tried to delete a team that had private branches in projects with branch visibility rules. Merge transfers artefacts that must have owners, such as as branches to ~registry. Merge oopses because ~registry does not have a policy for the project. Lp might want to ask the user to provide another team to transfer the branches too. Maybe Lp should explain the user might want to do a merge with a new team instead.
This error also happens when I attempt to merge the team into another team. I hoped that the branches and policies would be transferred to the new team. Lp really must support this case. The issue might be moot if branch branch visibility policies are replaced with project sharing policies and merge handles them properly.
OOPS-b2214aa38cea8f74df0b9d79b02ef765
BranchCreationForbidden: You cannot create branches in "~registry/<PROJECT>"
Traceback (most recent call last):
Module lp.services.job.runner, line 267, in runJobHandleError
self.runJob(job)
Module lp.services.job.runner, line 225, in runJob
job.run()
Module lp.registry.model.persontransferjob, line 427, in run
reviewer=self.reviewer)
Module lp.registry.model.person, line 4063, in delete
return self._merge(from_person, to_person, reviewer, True)
Module lp.registry.model.person, line 4165, in _merge
self._mergeBranches(from_person, to_person)
Module lp.registry.model.person, line 3611, in _mergeBranches
removeSecurityProxy(branch).setOwner(to_person, to_person)
Module lp.code.model.branch, line 220, in setOwner
new_namespace.moveBranch(self, user, rename_if_necessary=True)
Module lp.code.model.branchnamespace, line 199, in moveBranch
self.validateMove(branch, mover, new_name)
Module lp.code.model.branchnamespace, line 186, in validateMove
self.validateRegistrant(mover)
Module lp.code.model.branchnamespace, line 166, in validateRegistrant
'You cannot create branches in "%s"' % self.name)
BranchCreationForbidden: You cannot create branches in "~registry/<PROJECT>" |
|
| 2012-01-19 20:25:56 |
Curtis Hovey |
tags |
merge-deactivate oops teams |
disclosure merge-deactivate oops teams |
|
| 2012-01-30 17:43:09 |
Curtis Hovey |
launchpad: assignee |
|
Steve Kowalik (stevenk) |
|
| 2012-01-30 17:43:11 |
Curtis Hovey |
launchpad: status |
Triaged |
In Progress |
|
| 2012-03-19 14:01:59 |
Curtis Hovey |
launchpad: assignee |
Steve Kowalik (stevenk) |
|
|
| 2012-03-19 14:03:02 |
Curtis Hovey |
launchpad: status |
In Progress |
Triaged |
|
| 2012-06-25 19:43:47 |
Curtis Hovey |
tags |
disclosure merge-deactivate oops teams |
disclosure merge-deactivate oops sharing teams |
|
| 2012-06-26 23:02:05 |
Curtis Hovey |
description |
I tried to delete a team that had private branches in projects with branch visibility rules. Merge transfers artefacts that must have owners, such as as branches to ~registry. Merge oopses because ~registry does not have a policy for the project. Lp might want to ask the user to provide another team to transfer the branches too. Maybe Lp should explain the user might want to do a merge with a new team instead.
This error also happens when I attempt to merge the team into another team. I hoped that the branches and policies would be transferred to the new team. Lp really must support this case. The issue might be moot if branch branch visibility policies are replaced with project sharing policies and merge handles them properly.
OOPS-b2214aa38cea8f74df0b9d79b02ef765
BranchCreationForbidden: You cannot create branches in "~registry/<PROJECT>"
Traceback (most recent call last):
Module lp.services.job.runner, line 267, in runJobHandleError
self.runJob(job)
Module lp.services.job.runner, line 225, in runJob
job.run()
Module lp.registry.model.persontransferjob, line 427, in run
reviewer=self.reviewer)
Module lp.registry.model.person, line 4063, in delete
return self._merge(from_person, to_person, reviewer, True)
Module lp.registry.model.person, line 4165, in _merge
self._mergeBranches(from_person, to_person)
Module lp.registry.model.person, line 3611, in _mergeBranches
removeSecurityProxy(branch).setOwner(to_person, to_person)
Module lp.code.model.branch, line 220, in setOwner
new_namespace.moveBranch(self, user, rename_if_necessary=True)
Module lp.code.model.branchnamespace, line 199, in moveBranch
self.validateMove(branch, mover, new_name)
Module lp.code.model.branchnamespace, line 186, in validateMove
self.validateRegistrant(mover)
Module lp.code.model.branchnamespace, line 166, in validateRegistrant
'You cannot create branches in "%s"' % self.name)
BranchCreationForbidden: You cannot create branches in "~registry/<PROJECT>" |
I tried to delete a team that had private branches in projects with branch visibility rules. Merge transfers artefacts that must have owners, such as as branches to ~registry. Merge oopses because ~registry does not have a policy for the project. Lp might want to ask the user to provide another team to transfer the branches too. Maybe Lp should explain the user might want to do a merge with a new team instead.
This error also happens when I attempt to merge the team into another team. I hoped that the branches and policies would be transferred to the new team. Lp really must support this case. The issue might be moot if branch branch visibility policies are replaced with project sharing policies and merge handles them properly.
OOPS-b2214aa38cea8f74df0b9d79b02ef765
BranchCreationForbidden: You cannot create branches in "~registry/<PROJECT>"
Traceback (most recent call last):
Module lp.services.job.runner, line 267, in runJobHandleError
self.runJob(job)
Module lp.services.job.runner, line 225, in runJob
job.run()
Module lp.registry.model.persontransferjob, line 427, in run
reviewer=self.reviewer)
Module lp.registry.model.person, line 4063, in delete
return self._merge(from_person, to_person, reviewer, True)
Module lp.registry.model.person, line 4165, in _merge
self._mergeBranches(from_person, to_person)
Module lp.registry.model.person, line 3611, in _mergeBranches
removeSecurityProxy(branch).setOwner(to_person, to_person)
Module lp.code.model.branch, line 220, in setOwner
new_namespace.moveBranch(self, user, rename_if_necessary=True)
Module lp.code.model.branchnamespace, line 199, in moveBranch
self.validateMove(branch, mover, new_name)
Module lp.code.model.branchnamespace, line 186, in validateMove
self.validateRegistrant(mover)
Module lp.code.model.branchnamespace, line 166, in validateRegistrant
'You cannot create branches in "%s"' % self.name)
BranchCreationForbidden: You cannot create branches in "~registry/<PROJECT>"
While this bug will disappear when BVP is removed. We do not want ~registry to own private branches. The delete page must explain that the team cannot be deleted until the team's private branches are deleted or the ownership is transferred to another person. Delete may need to delete merged branches...the user needs to find all the other branches. |
|
| 2012-07-16 18:04:31 |
Curtis Hovey |
launchpad: assignee |
|
Curtis Hovey (sinzui) |
|
| 2012-07-16 18:04:34 |
Curtis Hovey |
launchpad: status |
Triaged |
In Progress |
|
| 2012-07-16 21:02:13 |
Curtis Hovey |
branch linked |
|
lp:~sinzui/launchpad/merge-and-private-branches |
|
| 2012-07-18 02:31:31 |
Launchpad QA Bot |
tags |
disclosure merge-deactivate oops sharing teams |
disclosure merge-deactivate oops qa-needstesting sharing teams |
|
| 2012-07-18 02:31:33 |
Launchpad QA Bot |
launchpad: status |
In Progress |
Fix Committed |
|
| 2012-07-18 04:30:57 |
Curtis Hovey |
tags |
disclosure merge-deactivate oops qa-needstesting sharing teams |
disclosure merge-deactivate oops qa-ok sharing teams |
|
| 2012-07-19 05:31:53 |
Steve Kowalik |
launchpad: status |
Fix Committed |
Fix Released |
|
