merge proposal is broken with consistent timeouts
Bug #911090 reported by
Lucio Torre
This bug affects 1 person
Affects | Status | Importance | Assigned to | Milestone | |
---|---|---|---|---|---|
Launchpad itself |
Fix Released
|
Critical
|
Aaron Bentley | ||
Tarmac |
Invalid
|
Undecided
|
Unassigned |
Bug Description
merge proposal is broken with consistent timeouts:
OOPS-1d94a4858bdc89ce60555859148a229
OOPS-e7a477631159e6498ee9048998f2747f
etc
while trying to open: https:/
Related branches
lp:~abentley/launchpad/attachment-timeout
- Brad Crittenden (community): Approve (code)
-
Diff: 1927 lines (+1549/-77)20 files modifiedlib/lp/app/browser/tales.py (+12/-5)
lib/lp/bugs/browser/bugcomment.py (+14/-0)
lib/lp/bugs/browser/configure.zcml (+7/-0)
lib/lp/bugs/browser/tests/test_bugcomment.py (+28/-0)
lib/lp/bugs/interfaces/bugmessage.py (+0/-1)
lib/lp/bugs/stories/bugs/xx-bug-comments-truncated.txt (+4/-0)
lib/lp/code/browser/branchmergeproposal.py (+6/-0)
lib/lp/code/browser/codereviewcomment.py (+19/-0)
lib/lp/code/browser/configure.zcml (+4/-0)
lib/lp/code/browser/tests/test_branchmergeproposal.py (+20/-0)
lib/lp/code/browser/tests/test_codereviewcomment.py (+35/-0)
lib/lp/registry/browser/distroseriesdifference.py (+4/-0)
lib/lp/registry/browser/tests/test_person.py (+1281/-0)
lib/lp/registry/browser/tests/test_person.py.OTHER (+0/-69)
lib/lp/services/comments/browser/comment.py (+53/-0)
lib/lp/services/comments/browser/configure.zcml (+1/-0)
lib/lp/services/comments/browser/messagecomment.py (+5/-0)
lib/lp/services/comments/browser/tests/test_comment.py (+40/-0)
lib/lp/services/comments/interfaces/conversation.py (+11/-0)
lib/lp/services/comments/templates/comment-body.pt (+5/-2)
lp:~abentley/launchpad/fix-index-download
- Deryck Hodge (community): Approve
-
Diff: 103 lines (+35/-15)3 files modifiedlib/lp/code/browser/codereviewcomment.py (+9/-6)
lib/lp/code/browser/configure.zcml (+7/-3)
lib/lp/code/browser/tests/test_branchmergeproposal.py (+19/-6)
Changed in launchpad: | |
status: | New → Triaged |
importance: | Undecided → Critical |
tags: | added: timeout |
Changed in launchpad: | |
assignee: | nobody → Launchpad Orange Squad (launchpad-orange-squad) |
Changed in launchpad: | |
assignee: | Launchpad Orange Squad (launchpad-orange-squad) → Aaron Bentley (abentley) |
tags: |
added: qa-bad removed: qa-needstesting |
tags: | added: bad-commit-14739 |
Changed in launchpad: | |
status: | Fix Committed → Fix Released |
status: | Fix Released → Fix Committed |
tags: |
added: qa-ok removed: qa-bad |
Changed in launchpad: | |
status: | Fix Committed → Fix Released |
Changed in tarmac: | |
status: | Incomplete → Invalid |
To post a comment you must log in.
The problem appears to be this comment: https:/ /code.launchpad .net/~lucio. torre/txstatsd/ add-redis- to-distinct- plugin/ +merge/ 86438/comments/ 186681
It is 16MB, so it cannot be displayed without exceeding our timeout. It contains a list of test failures, some or all of them due to "redis. exceptions. ConnectionError : Error 111 connecting localhost:16379. Connection refused"