class="highlight" and class="highlighted" shouldn't coexist
Bug #90502 reported by
Matthew Paul Thomas
| Affects | Status | Importance | Assigned to | Milestone | |
|---|---|---|---|---|---|
| Launchpad itself |
Fix Released
|
Low
|
Unassigned | ||
Bug Description
The 1.0 CSS currently has both a "highlight" class (used, for example, to highlight the current context in bug pages) and a "highlighted" class (used, for example, to highlight the development focus in product pages). These shouldn't both exist.
Related branches
lp:~sinzui/launchpad/css-ui-1
- Brad Crittenden (community): Approve (code)
-
Diff: 814 lines (+178/-162)16 files modifiedlib/canonical/launchpad/icing/style-3-0.css.in (+20/-10)
lib/canonical/launchpad/icing/style.css (+0/-19)
lib/canonical/launchpad/webapp/error.py (+1/-1)
lib/lp/answers/stories/project-add-question.txt (+105/-90)
lib/lp/answers/stories/questions-index.txt (+3/-3)
lib/lp/answers/templates/question-listing-detailed.pt (+2/-2)
lib/lp/registry/browser/distribution.py (+5/-4)
lib/lp/registry/browser/product.py (+5/-4)
lib/lp/registry/browser/tests/distribution-views.txt (+4/-4)
lib/lp/registry/stories/distributionmirror/xx-distribution-mirrors.txt (+18/-10)
lib/lp/registry/stories/productseries/xx-productseries-series.txt (+4/-4)
lib/lp/registry/templates/distributionmirror-macros.pt (+3/-3)
lib/lp/registry/templates/productreleasefile-macros.pt (+1/-1)
lib/lp/registry/templates/team-editproposed.pt (+2/-2)
lib/lp/soyuz/browser/sourcepackagerelease.py (+1/-1)
lib/lp/soyuz/browser/tests/test_sourcepackagerelease.py (+4/-4)
| Changed in launchpad-foundations: | |
| status: | New → Triaged |
| importance: | Undecided → Low |
| assignee: | nobody → Martin Albisetti (beuno) |
Revision history for this message
| Gary Poster (gary) wrote | #1 |
| tags: | added: css |
| Changed in launchpad-foundations: | |
| assignee: | Martin Albisetti (beuno) → nobody |
| affects: | launchpad-foundations → launchpad-web |
| Changed in launchpad: | |
| assignee: | nobody → Curtis Hovey (sinzui) |
| status: | Triaged → In Progress |
| tags: | added: bugjam2010 |
Revision history for this message
| Launchpad QA Bot (lpqabot) wrote Bug fixed by a commit | #2 |
| tags: | added: qa-needstesting |
| Changed in launchpad: | |
| status: | In Progress → Fix Committed |
| tags: |
added: qa-ok removed: qa-needstesting |
| Changed in launchpad: | |
| status: | Fix Committed → Fix Released |
| Changed in launchpad: | |
| milestone: | none → 11.01 |
| Changed in launchpad: | |
| assignee: | Curtis Hovey (sinzui) → nobody |
To post a comment you must log in.
It looks like this is still the case. Most places have class="highlight" but "highlighted" is used in some places as well.
Examples as of this writing:
./lib/lp/
./lib/lp/
./lib/lp/
./lib/lp/
./lib/lp/
./lib/canonical
./lib/canonical
./sourcecode/
I'm assigning to Martin in the hopes that he can clarify what ought to be done (or if I'm wrong and this bug should be closed).