It would be nice if the diffs sent by launchpad could be generated with --diff-options=-p

Bug #904204 reported by James Troup
12
This bug affects 2 people
Affects Status Importance Assigned to Milestone
Launchpad itself
Triaged
Low
Unassigned

Bug Description

It'd be nice if the bzr diffs sent in email by Launchpad could be
generated with --diff-options=-p.

I don't know if it's viable to change globally, if not, it's probably
not worth the complexity of per branch/user/subscription config
options.

Benji York (benji)
Changed in launchpad:
status: New → Triaged
importance: Undecided → Low
Revision history for this message
gue5t gue5t (gue5t) wrote :

This would also be really nice in the diffs shown in merge requests. I think there's no context where it's better to not use "diff -p", usability-wise. At present the diffs are essentially useless for reviewing code because even good changes to code may need a r- if they cause a function name to become no-longer-correct, so one has to check out the branch and run bzr diff manually.

To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.