garbo.py not threadsafe (fails with IndexError due to race condition)
Bug #893720 reported by
Stuart Bishop
This bug affects 1 person
| Affects | Status | Importance | Assigned to | Milestone | |
|---|---|---|---|---|---|
| Launchpad itself |
Fix Released
|
Critical
|
Stuart Bishop | ||
Bug Description
Looks like a race condition that a simple guard should avoid.
Exception in thread Worker-5:
Traceback (most recent call last):
File "/usr/lib/
self.run()
File "/usr/lib/
self.
File "/srv/launchpad
tunable_
IndexError: pop from empty list
Related branches
lp:~stub/launchpad/garbo
- Curtis Hovey (community): Approve (code)
-
Diff: 29 lines (+7/-4)1 file modifiedlib/lp/scripts/garbo.py (+7/-4)
- Robert Collins (community): Needs Fixing
-
Diff: 466 lines (+148/-83)5 files modifiedcronscripts/garbo-frequently.py (+23/-0)
database/schema/security.cfg (+4/-0)
lib/canonical/launchpad/utilities/looptuner.py (+1/-1)
lib/lp/scripts/garbo.py (+67/-47)
lib/lp/scripts/tests/test_garbo.py (+53/-35)
| Changed in launchpad: | |
| status: | New → Triaged |
| importance: | Undecided → High |
| tags: | added: trivial |
Revision history for this message
| Robert Collins (lifeless) wrote | #1 |
| summary: |
- garbo.py fails with IndexError due to race condition + garbo.py not threadsafe (fails with IndexError due to race condition) |
| Changed in launchpad: | |
| importance: | High → Critical |
| tags: | added: oops should-oops |
| Changed in launchpad: | |
| assignee: | nobody → Stuart Bishop (stub) |
Revision history for this message
| Launchpad QA Bot (lpqabot) wrote | #2 |
| tags: | added: qa-untestable |
| Changed in launchpad: | |
| status: | Triaged → Fix Committed |
| Changed in launchpad: | |
| status: | Fix Committed → Fix Released |
To post a comment you must log in.
Use a threaded queue, will be simplest