Email too big message not helpful
| Affects | Status | Importance | Assigned to | Milestone | |
|---|---|---|---|---|---|
| | Launchpad itself |
Critical
|
Martin Pool | ||
Bug Description
When someone sends an oversize email they receive a response consisting of a OOPS number instead of an explanation of the problem. Instead I would expect a message simply stating the the message was too big and needs to be smaller than MAX_EMAIL_SIZE. I would also expect that no OOPS be recorded for this situation.
OOPS-1999d3841c611d408bc931b0b97d967c (from https:/
Related branches
- Ian Booth (community): Approve on 2012-04-13
-
Diff: 141 lines (+56/-12)4 files modifiedlib/lp/services/mail/incoming.py (+21/-1)
lib/lp/services/mail/signedmessage.py (+6/-1)
lib/lp/services/mail/tests/test_incoming.py (+27/-1)
lib/lp/services/messages/model/message.py (+2/-9)
- Ian Booth: Pending requested 2012-04-16
- Diff: 0 lines
| Gavin Panella (allenap) wrote : | #1 |
| tags: | added: email |
| Martin Pool (mbp) wrote : | #2 |
I might look at it, feel free to steal it back.
| Changed in launchpad: | |
| assignee: | nobody → Martin Pool (mbp) |
| Martin Pool (mbp) wrote : | #3 |
I'm trying to reproduce this or write a test for it, and I don't see an oops at the moment even when processing a very large mail... My attempted reproduction, by running process-one-mail, might not be realistic.
| Changed in launchpad: | |
| status: | Triaged → In Progress |
| Launchpad QA Bot (lpqabot) wrote : | #4 |
Fixed in stable r15100 <http://
| tags: | added: qa-needstesting |
| Changed in launchpad: | |
| status: | In Progress → Fix Committed |
| tags: |
added: qa-ok removed: qa-needstesting |
| Changed in launchpad: | |
| status: | Fix Committed → Fix Released |
Marked as Critical per zero-OOPS policy.