Feature flags are not accessible in JavaScript.
Bug #891714 reported by
Aaron Bentley
This bug affects 1 person
Affects | Status | Importance | Assigned to | Milestone | |
---|---|---|---|---|---|
Launchpad itself |
Fix Released
|
High
|
Aaron Bentley |
Bug Description
We sometimes wish to enable and disable javascript-based features, so there should be a uniform way of accessing feature flags in JavaScript.
Related branches
lp:~abentley/launchpad/view-flags
- Gavin Panella (community): Approve
-
Diff: 495 lines (+159/-117)7 files modifiedlib/canonical/launchpad/webapp/publisher.py (+25/-25)
lib/canonical/launchpad/webapp/tests/test_publisher.py (+87/-63)
lib/canonical/launchpad/webapp/tests/test_view_model.py (+3/-3)
lib/lp/app/javascript/beta-notification.js (+11/-16)
lib/lp/app/javascript/tests/test_beta_notification.html (+2/-0)
lib/lp/app/javascript/tests/test_beta_notification.js (+30/-9)
lib/lp/bugs/browser/bugtask.py (+1/-1)
Changed in launchpad: | |
assignee: | nobody → Aaron Bentley (abentley) |
status: | Triaged → In Progress |
tags: |
added: qa-ok removed: qa-needstesting |
Changed in launchpad: | |
status: | Fix Committed → Fix Released |
To post a comment you must log in.
Thanks for doing this, I'm very glad to see you took a whitelist
approach where only select flags are exposed. Nice (and necessary -
some flag values may be confidential).
speculation: I wonder if we should also expose a list of *requestable*
flags, to let browsers opt in (e.g. via cookies) similar to google
labs.