raw_sendmail creates TimedActions with invalid detail

Bug #885972 reported by William Grant
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Launchpad itself
Fix Released
Critical
Martin Pool

Bug Description

TimedAction.detail is meant to be a string, so it can be encoded by the various OOPS backends (RFC822, JSON, BSON, etc.). But lp.services.mail.sendmail.raw_sendmail sets detail to message_detail, which is an email.header.Header. This is particularly problematic for the BSON backend, because the Python bson package silently omits unknown types, leaving the action without a detail element.

Related branches

tags: added: oops-infrastructure
Revision history for this message
Martin Pool (mbp) wrote : Re: [Bug 885972] Re: raw_sendmail creates TimedActions with invalid detail

  assigned mbp

i'll have a look but feel free to steal it

Martin Pool (mbp)
Changed in launchpad:
assignee: nobody → Martin Pool (mbp)
Revision history for this message
Martin Pool (mbp) wrote :

    # Note that raw_sendail has no tests, unit or otherwise.
:/

Martin Pool (mbp)
Changed in launchpad:
status: Triaged → In Progress
Revision history for this message
Launchpad QA Bot (lpqabot) wrote :
tags: added: qa-needstesting
Changed in launchpad:
status: In Progress → Fix Committed
Revision history for this message
Martin Pool (mbp) wrote :

qa-ok: qastaging is still sending mail with this code deployed.

> # Note that raw_sendail has no tests, unit or otherwise.

fixed.

tags: added: qa-ok
removed: qa-needstesting
Raphaël Badin (rvb)
Changed in launchpad:
status: Fix Committed → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.