raw_sendmail creates TimedActions with invalid detail

Bug #885972 reported by William Grant on 2011-11-04
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Launchpad itself
Critical
Martin Pool

Bug Description

TimedAction.detail is meant to be a string, so it can be encoded by the various OOPS backends (RFC822, JSON, BSON, etc.). But lp.services.mail.sendmail.raw_sendmail sets detail to message_detail, which is an email.header.Header. This is particularly problematic for the BSON backend, because the Python bson package silently omits unknown types, leaving the action without a detail element.

Related branches

tags: added: oops-infrastructure

  assigned mbp

i'll have a look but feel free to steal it

Martin Pool (mbp) on 2011-11-20
Changed in launchpad:
assignee: nobody → Martin Pool (mbp)
Martin Pool (mbp) wrote :

    # Note that raw_sendail has no tests, unit or otherwise.
:/

Martin Pool (mbp) on 2011-11-21
Changed in launchpad:
status: Triaged → In Progress
Launchpad QA Bot (lpqabot) wrote :
tags: added: qa-needstesting
Changed in launchpad:
status: In Progress → Fix Committed
Martin Pool (mbp) wrote :

qa-ok: qastaging is still sending mail with this code deployed.

> # Note that raw_sendail has no tests, unit or otherwise.

fixed.

tags: added: qa-ok
removed: qa-needstesting
Raphaël Badin (rvb) on 2011-11-24
Changed in launchpad:
status: Fix Committed → Fix Released
To post a comment you must log in.
This report contains Public information  Edit
Everyone can see this information.

Other bug subscribers