queue and override manipulations should have an audit trail
Affects | Status | Importance | Assigned to | Milestone | |
---|---|---|---|---|---|
Launchpad itself |
Fix Released
|
High
|
Thiago F. Pappacena |
Bug Description
There are several archive administration tasks that we really need an audit trail for. Removals already get a blame tag on them, which is lovely, but we'd like to see a similar blame on other manipulations, at the very least packages moving to the accepted queue, and overrides being updated.
I suspect that both of these could, at least for now, be represented in the publishing history (since accepts and overrides both create a publishing record), which should be reasonably simple given that package removals are already represented in the same UI. Not sure how the schema will deal sanely with this, but my hope is that this won't be much effort.
(Note that while I'm sure there's some interest in writing a more involved auditing scheme and fancy UIs around such, we're much more interested in having accept/override auditing Very Soon than we are in having something fancy Some Day)
Related branches
- Stuart Bishop (community): Approve (db)
- Robert Collins: Pending (db) requested
-
Diff: 24 lines (+9/-0)2 files modifieddatabase/schema/comments.sql (+1/-0)
database/schema/patch-2209-15-0.sql (+8/-0)
- Curtis Hovey (community): Approve (code)
-
Diff: 307 lines (+75/-17)9 files modifiedlib/lp/_schema_circular_imports.py (+3/-1)
lib/lp/soyuz/interfaces/publishing.py (+15/-1)
lib/lp/soyuz/model/packagecopyjob.py (+1/-1)
lib/lp/soyuz/model/publishing.py (+9/-4)
lib/lp/soyuz/model/queue.py (+3/-2)
lib/lp/soyuz/scripts/packagecopier.py (+8/-5)
lib/lp/soyuz/stories/webservice/xx-source-package-publishing.txt (+1/-0)
lib/lp/soyuz/tests/test_packagecopyjob.py (+23/-1)
lib/lp/soyuz/tests/test_packageupload.py (+12/-2)
- William Grant (community): Approve (code)
-
Diff: 177 lines (+133/-1)2 files modifiedlib/lp/scripts/garbo.py (+78/-1)
lib/lp/scripts/tests/test_garbo.py (+55/-0)
- j.c.sackett (community): Approve
-
Diff: 335 lines (+137/-49)11 files modifiedlib/lp/services/auditor/client.py (+43/-0)
lib/lp/services/auditor/tests/test_client.py (+27/-0)
lib/lp/services/config/schema-lazr.conf (+5/-0)
lib/lp/services/enterpriseid.py (+7/-6)
lib/lp/services/features/flags.py (+6/-0)
lib/lp/soyuz/browser/queue.py (+1/-1)
lib/lp/soyuz/interfaces/queue.py (+2/-1)
lib/lp/soyuz/model/queue.py (+6/-1)
lib/lp/testing/layers.py (+36/-38)
setup.py (+1/-0)
versions.cfg (+3/-2)
- Ian Booth (community): Approve
-
Diff: 56 lines (+9/-5)3 files modifiedlib/lp/soyuz/browser/queue.py (+3/-3)
lib/lp/soyuz/interfaces/queue.py (+2/-1)
lib/lp/soyuz/model/queue.py (+4/-1)
- Colin Watson (community): Approve
-
Diff: 569 lines (+276/-51)10 files modifiedlib/lp/_schema_circular_imports.py (+4/-0)
lib/lp/soyuz/browser/publishing.py (+31/-1)
lib/lp/soyuz/interfaces/publishing.py (+22/-2)
lib/lp/soyuz/model/publishing.py (+20/-4)
lib/lp/soyuz/scripts/tests/test_copypackage.py (+32/-1)
lib/lp/soyuz/stories/ppa/xx-copy-packages.txt (+2/-2)
lib/lp/soyuz/stories/soyuz/xx-packagepublishinghistory.txt (+79/-2)
lib/lp/soyuz/stories/webservice/xx-binary-package-publishing.txt (+1/-0)
lib/lp/soyuz/stories/webservice/xx-source-package-publishing.txt (+1/-0)
lib/lp/soyuz/templates/packagepublishing-details.pt (+84/-39)
- Colin Watson (community): Approve
-
Diff: 331 lines (+131/-10)7 files modifiedlib/lp/soyuz/interfaces/publishing.py (+13/-3)
lib/lp/soyuz/model/publishing.py (+11/-3)
lib/lp/soyuz/stories/soyuz/xx-packagepublishinghistory.txt (+27/-0)
lib/lp/soyuz/stories/webservice/xx-binary-package-publishing.txt (+1/-0)
lib/lp/soyuz/templates/packagepublishing-details.pt (+8/-0)
lib/lp/soyuz/tests/test_publishing.py (+67/-2)
lib/lp/testing/factory.py (+4/-2)
- Colin Watson (community): Approve
-
Diff: 625 lines (+271/-22)9 files modifiedlib/lp/security.py (+11/-1)
lib/lp/soyuz/browser/queue.py (+32/-4)
lib/lp/soyuz/browser/tests/test_queue.py (+32/-4)
lib/lp/soyuz/configure.zcml (+8/-1)
lib/lp/soyuz/interfaces/queue.py (+37/-4)
lib/lp/soyuz/model/queue.py (+77/-5)
lib/lp/soyuz/stories/soyuz/xx-queue-pages.txt (+25/-0)
lib/lp/soyuz/templates/distroseries-queue.pt (+10/-0)
lib/lp/soyuz/tests/test_packageupload.py (+39/-3)
- Colin Watson (community): Approve (db)
-
Diff: 73 lines (+30/-1)2 files modifieddatabase/schema/patch-2210-11-0.sql (+25/-0)
database/schema/security.cfg (+5/-1)
Changed in launchpad: | |
status: | Fix Committed → In Progress |
tags: |
added: qa-ok removed: qa-needstesting |
tags: |
added: qa-ok removed: qa-needstesting |
tags: |
added: qa-ok removed: qa-needstesting |
tags: |
added: qa-untestable removed: qa-needstesting |
tags: |
added: qa-untestable removed: qa-needstesting |
Changed in launchpad: | |
status: | In Progress → Fix Released |
Changed in launchpad: | |
status: | Fix Released → In Progress |
Changed in launchpad: | |
status: | In Progress → Triaged |
tags: | added: package-overrides |
Changed in launchpad: | |
status: | In Progress → Fix Released |
SPPH can easily store a Person to record who dunnit.