Users make bugs private because they cannot hide comments
Affects | Status | Importance | Assigned to | Milestone | |
---|---|---|---|---|---|
Launchpad itself |
Fix Released
|
High
|
Ian Booth |
Bug Description
The analysis of private bugs with subscribed open teams revealed that 90% were made private to hide the content of one of more comments. Either the user who owns the comment, or the project's owner, driver, or bug supervisor made the bug private. About 15% of these bugs affected more than one projects; such bugs will not be privatable in the near future.
We want to permit the owner of the comment and the users in project roles to hide comment \o/
The permission revision may be trivial, but there UI needs review. For two reasons: 1, we show the hide comment action on every comment, and 2, hidden comments have a florescent yellow background. Both issues were brought up when comment hiding was added and it was decided that it was not important because the issue affects ~registry.
Related branches
- Curtis Hovey (community): Approve (code)
-
Diff: 666 lines (+298/-37)17 files modifiedlib/lp/answers/browser/tests/test_questionmessages.py (+1/-1)
lib/lp/bugs/browser/bugcomment.py (+11/-4)
lib/lp/bugs/browser/bugtask.py (+7/-5)
lib/lp/bugs/browser/tests/test_bugcomment.py (+54/-2)
lib/lp/bugs/configure.zcml (+2/-1)
lib/lp/bugs/interfaces/bug.py (+19/-0)
lib/lp/bugs/model/bug.py (+36/-1)
lib/lp/bugs/security.py (+0/-9)
lib/lp/bugs/tests/test_bug_messages.py (+70/-1)
lib/lp/bugs/tests/test_bug_messages_webservice.py (+52/-12)
lib/lp/coop/answersbugs/visibility.py (+1/-1)
lib/lp/registry/interfaces/role.py (+6/-0)
lib/lp/registry/model/personroles.py (+12/-0)
lib/lp/registry/tests/test_personroles.py (+12/-0)
lib/lp/services/features/flags.py (+6/-0)
lib/lp/services/messages/configure.zcml (+6/-0)
lib/lp/services/messages/model/message.py (+3/-0)
Changed in launchpad: | |
assignee: | nobody → Ian Booth (wallyworld) |
status: | Triaged → In Progress |
tags: |
added: qa-ok removed: qa-needstesting |
Changed in launchpad: | |
status: | Fix Committed → In Progress |
Changed in launchpad: | |
status: | Fix Committed → In Progress |
tags: | added: information-type |
Changed in launchpad: | |
status: | In Progress → Fix Released |
i think there are other bugs for the ugly ui