Do not permit open/delegated teams to subscribe to private bugs
| Affects | Status | Importance | Assigned to | Milestone | |
|---|---|---|---|---|---|
| Launchpad itself |
Fix Released
|
High
|
j.c.sackett | ||
Bug Description
A review of data revealed that there were/are open or delegated teams subscribed to private bugs. 95% of the affected bugs are unwanted; duplicates, invalid, wontfix, expired, questions, tests. This issue does not appear to have been the cause of a serious compromise, they are more often accidental subscriptions that users do not want to see.
SELECT distinct
product, productseries, distribution, distroseries, bs.bug, t.name
FROM person t
JOIN bugsubscription bs ON bs.person = t.id
JOIN bug ON bug.id = bs.bug
JOIN bugtask ON bugtask.bug = bug.id
WHERE
bug.private
AND t.subscriptionp
ORDER BY t.name, product, productseries, distribution, distroseries;
Lp must ensure that open teams cannot subscribe to private bugs or be assigned private bugs.
Related branches
- Robert Collins (community): Approve
-
Diff: 238 lines (+88/-12)8 files modifiedlib/lp/bugs/browser/bugsubscription.py (+11/-6)
lib/lp/bugs/browser/tests/test_bugsubscription_views.py (+41/-1)
lib/lp/bugs/doc/bugsummary.txt (+9/-2)
lib/lp/bugs/errors.py (+5/-0)
lib/lp/bugs/model/bug.py (+9/-2)
lib/lp/registry/browser/tests/test_milestone.py (+3/-1)
lib/lp/registry/interfaces/person.py (+3/-0)
lib/lp/registry/model/person.py (+7/-0)
- Brad Crittenden (community): Approve (code)
-
Diff: 22 lines (+8/-2)1 file modifiedlib/lp/app/javascript/subscribers/subscribers_list.js (+8/-2)
| summary: |
- do not permit open/delegated teams to subscribe to private bugs + Do not permit open/delegated teams to subscribe to private bugs |
| Changed in launchpad: | |
| assignee: | nobody → j.c.sackett (jcsackett) |
| Changed in launchpad: | |
| status: | Triaged → In Progress |
| Launchpad QA Bot (lpqabot) wrote | #1 |
| tags: | added: qa-needstesting |
| Changed in launchpad: | |
| status: | In Progress → Fix Committed |
| Changed in launchpad: | |
| status: | Fix Committed → In Progress |
| tags: |
added: qa-ok removed: qa-needstesting |
| Launchpad QA Bot (lpqabot) wrote | #2 |
| tags: |
added: qa-needstesting removed: qa-ok |
| Changed in launchpad: | |
| status: | In Progress → Fix Committed |
| tags: |
added: qa-ok removed: qa-needstesting |
| Changed in launchpad: | |
| status: | Fix Committed → Fix Released |
| visibility: | private → public |
Fixed in stable r14287 <http://