"Hide comment" link appears for comments if the comment has been viewed by an admin, with memcache on

[Graham Binns]

From Andrea Corbellini's comments on the batched-comments story:

> 1. The comments that are shown via AJAX contain a "Hide comment" button
> that seems to have no visible effect.
>
> 2. The "Hide comment" button is only visible for the comments which were
> loaded via AJAX, it is not possible to hide other comments (i.e.
> the ones that were shown by default).
>
> 3. The pencil icon near "Hide comment" makes me think that Launchpad
> will remember my choice to hide the comment, although I doubt it
> will do. If I'm not the only one who has noticed this, I think that
> the icon should be changed.

These comments suggest that Andrea is seeing the "Hide comment" link even though this link should only be visible to members of ~launchpad.

Michael Hudson thinks this might be a memcache issue:

> I expect this is wonky use of memcache -- it's turned off via a feature
> flag for the bugtask:+index pages, but I guess not for whichever view
> the ajax is hitting?

... and Rob agrees:

> Probably. Perhaps time to default it off globally and turn it on for
> the one page we know benefits - the front page.

[Robert Collins (lifeless)]

Theres still a code change to make here: the template causing memcache caching of comments is wrong - they are no longer safe to cache across users (and so there is no reason to cache at all).

[Robert Collins (lifeless)]

This is a regression added when the hide-a-comment button was added.

[Launchpad QA Bot (lpqabot)]

Fixed in stable r15393 <http://bazaar.launchpad.net/~launchpad-pqm/launchpad/stable/revision/15393>.