set_up_tacfile_logging is a little confused

[Robert Collins]

What it actually does is:
writes log messages to a stream, which then reflects them into twisted messages.

However a log message might be multiline in the first place, it would be better to just directly reflect the messages into twisted log messages. Probably best done as a logging->log bridge in upstream twisted.

[Robert Collins (lifeless)]

Note that this has only one user (sftp-poppy), it may be worth just nuking it in favour of lp.services.logger(), because the SSHService sets up the oops configuration (startService calls set_up_oops_reporting).

[Robert Collins (lifeless)]

(options can be None which will check the environment for -v -q etc.)

However, even then - the integration across the board should be turning exceptions into failures, not messages, and making sure that high severity log messages become oopses (they don't today, but its systematic across our twisted-using-zope-code daemons, so am filing a separate bug about that).