pageid: feature rules are broken

[Curtis Hovey]

There is a combination of factors that lead non ~registry members to see the Hide comment action on the first comment of
bug 4730. The action does not work since the user does not have permission, it is just being displayed by the javascript when it should not.

I suspect the javascript is confused by the comment+status change from the email that made the first comment. Since this does not happen on subsequent comments in the bug, the position of the comment may also be a factor.

[Michael Hudson-Doyle (mwhudson)]

This is because the rendered bugcomment is cached in memcache. From bugcomment-box.pt:

  tal:content="cache:authenticated noparam,comment/rendered_cache_time,comment/index">

I guess this needs to not cache if show_spam_controls is true, or make show_spam_controls part of the key, or something.

[Robert Collins (lifeless)]

Ah, I suspect I know whats up.

feature flags are broken.
-> memcache is reenabled

Once we deploy the fix to reenable feature flags, we should be all good.

We *do* have a latent defect here and we should fix it (by disabling memcache for comments)

[Robert Collins (lifeless)]

More complex than I thought, we didn't know that pageid: was bust, so its not clear whats up.

[Michael Hudson-Doyle (mwhudson)]

This is how we know pageid: was broken :-) (it was)