No indication when a job resulted in a user error
Bug #850974 reported by
Aaron Bentley
This bug affects 1 person
Affects | Status | Importance | Assigned to | Milestone | |
---|---|---|---|---|---|
Launchpad itself |
Fix Released
|
Critical
|
Martin Pool |
Bug Description
Log entries sometimes indicate that the job was incomplete, but there is no oops. Inspection of the code suggests that it could have been due to a user_error being raised. It should be clear when this is the case, and what error was raised. It may also be due to suprocess-side log messages not propagating through Twisted.
2011-09-15 11:57:42 DEBUG Running <UPDATE_
2011-09-15 11:57:42 DEBUG Incomplete <UPDATE_
Related branches
lp:~mbp/launchpad/612171-diff-generation-spam
- Aaron Bentley (community): Approve
- Ian Booth: Pending requested
-
Diff: 186 lines (+56/-9)4 files modifiedlib/lp/code/errors.py (+16/-1)
lib/lp/code/model/branchmergeproposaljob.py (+11/-7)
lib/lp/code/model/tests/test_branchmergeproposaljobs.py (+27/-1)
lib/lp/services/job/runner.py (+2/-0)
summary: |
- No indication when a job resulted in a user error or retry + No indication when a job resulted in a user error |
Changed in launchpad: | |
status: | New → Triaged |
importance: | Undecided → Critical |
Changed in launchpad: | |
assignee: | nobody → Aaron Bentley (abentley) |
status: | Triaged → In Progress |
Changed in launchpad: | |
assignee: | Aaron Bentley (abentley) → Martin Pool (mbp) |
tags: | added: qa-untestable |
tags: |
added: qa-untestable removed: qa-needstesting |
Changed in launchpad: | |
status: | Fix Committed → Fix Released |
To post a comment you must log in.
Fixed in stable r14238 <http:// bazaar. launchpad. net/~launchpad- pqm/launchpad/ stable/ revision/ 14238>.