lp.codehosting.safe_open should be in bzrlib
Bug #850843 reported by
Jelmer Vernooij
This bug affects 1 person
| Affects | Status | Importance | Assigned to | Milestone | |
|---|---|---|---|---|---|
| Bazaar |
Fix Released
|
Low
|
Jelmer Vernooij | ||
| Launchpad itself |
Triaged
|
Low
|
Unassigned | ||
Bug Description
Launchpad has some infrastructure for safely opening branches - it will call a policy object to verify any branch references it follows or stacked branches it opens.
This code is now generic enough to be useful for other bzrlib users so it should ideally be in bzrlib rather than lp.codehosting.
Related branches
lp:~jelmer/bzr/safe-open
- Martin Packman (community): Approve
-
Diff: 709 lines (+675/-0)4 files modifiedbzrlib/tests/__init__.py (+1/-0)
bzrlib/tests/test_url_policy_open.py (+357/-0)
bzrlib/url_policy_open.py (+314/-0)
doc/en/release-notes/bzr-2.5.txt (+3/-0)
- Martin Packman (community): Needs Fixing
-
Diff: 709 lines (+675/-0)4 files modifiedbzrlib/tests/__init__.py (+1/-0)
bzrlib/tests/test_url_policy_open.py (+357/-0)
bzrlib/url_policy_open.py (+314/-0)
doc/en/release-notes/bzr-2.5.txt (+3/-0)
lp:~jelmer/launchpad/use-bzr-policy-open
- j.c.sackett (community): Approve
-
Diff: 1424 lines (+95/-830)16 files modifiedlib/launchpad_loggerhead/app.py (+2/-2)
lib/lp/code/bzr.py (+0/-1)
lib/lp/code/interfaces/branch.py (+1/-1)
lib/lp/code/model/branch.py (+2/-2)
lib/lp/code/model/tests/test_branch.py (+3/-3)
lib/lp/codehosting/codeimport/tests/test_worker.py (+17/-17)
lib/lp/codehosting/codeimport/worker.py (+13/-12)
lib/lp/codehosting/puller/tests/__init__.py (+1/-1)
lib/lp/codehosting/puller/tests/test_errors.py (+4/-4)
lib/lp/codehosting/puller/tests/test_worker.py (+24/-24)
lib/lp/codehosting/puller/tests/test_worker_formats.py (+2/-2)
lib/lp/codehosting/puller/worker.py (+23/-22)
lib/lp/codehosting/safe_open.py (+0/-354)
lib/lp/codehosting/scanner/tests/test_bzrsync.py (+2/-2)
lib/lp/codehosting/tests/test_safe_open.py (+0/-382)
scripts/code-import-worker.py (+1/-1)
| tags: | added: codehosting |
| tags: |
added: lp-code removed: codehosting |
| Changed in launchpad: | |
| status: | New → Triaged |
| importance: | Undecided → Low |
| Changed in bzr: | |
| status: | Confirmed → In Progress |
| assignee: | nobody → Jelmer Vernooij (jelmer) |
| Changed in bzr: | |
| milestone: | none → 2.5b6 |
| status: | In Progress → Fix Released |
| Changed in launchpad: | |
| status: | Triaged → In Progress |
| assignee: | nobody → Jelmer Vernooij (jelmer) |
| Changed in launchpad: | |
| status: | In Progress → Triaged |
| assignee: | Jelmer Vernooij (jelmer) → nobody |
To post a comment you must log in.
