Autolinked bugs should also have title attribute with bug title

Bug #849121 reported by Nigel Babu
8
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Launchpad itself
Fix Released
Low
Nigel Babu

Bug Description

Bug 4595 introduced features to +check-links API for checking if a list of bugs are valid. Currently, it only returns invalid bug numbers and a message as to why they are invalid. Ideally, it should also return valid bugs with title and it should get updated on the page.

Tags: qa-ok

Related branches

Nigel Babu (nigelbabu)
Changed in launchpad:
assignee: nobody → Nigel Babu (nigelbabu)
Nigel Babu (nigelbabu)
description: updated
Deryck Hodge (deryck)
Changed in launchpad:
status: New → In Progress
importance: Undecided → Low
Revision history for this message
Launchpad QA Bot (lpqabot) wrote :
tags: added: qa-needstesting
Changed in launchpad:
status: In Progress → Fix Committed
Revision history for this message
Nigel Babu (nigelbabu) wrote :

Tested on https://bugs.qastaging.launchpad.net/ubuntu/oneiric/+source/phaseshift/+bug/755937 to get a traceback

TB from +check-links

Module zope.publisher.publish, line 134, in publish<
    result = publication.callObject(request, obj)

Module canonical.launchpad.webapp.publication, line 498, in callObject
    return mapply(ob, request.getPositionalArguments(), request)

Module zope.publisher.publish, line 109, in mapply<
    return debug_call(obj, args)<
__traceback_info__: <bound method LinkCheckerAPI.__call__ of <zope.browserpage.metaconfigure.LinkCheckerAPI object at 0xceb2210>>

Module zope.publisher.publish, line 115, in debug_call
    return obj(*args)

Module lp.app.browser.linkchecker, line 68, in __call__
    link_info = self.link_checkers[link_type](links)

Module lp.app.browser.linkchecker, line 103, in check_bug_links
    bugs_ids.remove(task.bug.id)

KeyError: 755941

tags: added: qa-bad
removed: qa-needstesting
Revision history for this message
Launchpad QA Bot (lpqabot) wrote :
tags: added: qa-needstesting
removed: qa-bad
William Grant (wgrant)
tags: added: bad-commit-13967
Revision history for this message
Curtis Hovey (sinzui) wrote :

I see a new error on bug 755937 that is being used the for test:
Uncaught TypeError: Cannot read property 'invalid' of undefined
process_links
Y.lp.app.links.check_valid_lp_links.config.on.success
b.Subscriber._notify
b.Subscriber.notify
b.CustomEvent._notify
b.CustomEvent._procSubs
b.CustomEvent.fireSimple
b.CustomEvent.fire

tags: added: qa-bad
removed: qa-needstesting
Revision history for this message
William Grant (wgrant) wrote :

I forgot the rollback tags, but hopefully this is fixed in r13979.

tags: added: bad-commit-13977
Revision history for this message
Launchpad QA Bot (lpqabot) wrote :
tags: added: qa-needstesting
removed: qa-bad
Revision history for this message
Nigel Babu (nigelbabu) wrote :
tags: added: qa-ok
removed: qa-needstesting
Revision history for this message
William Grant (wgrant) wrote :

Deployable up to the fix.

tags: removed: bad-commit-13967 bad-commit-13977
William Grant (wgrant)
Changed in launchpad:
status: Fix Committed → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.