ZopeViewReplacementFixture.tearDown is never called
Bug #847738 reported by
Gavin Panella
This bug affects 1 person
| Affects | Status | Importance | Assigned to | Milestone | |
|---|---|---|---|---|---|
| Launchpad itself |
Fix Released
|
High
|
Unassigned | ||
Bug Description
ZopeViewReplace
arranges for it to be called.
Some background: fixtures.Fixture does not look for a tearDown
method. Instead setUp should use addCleanup to arrange for tear down
functions to be called (or the fixture should override cleanUp, but I
suspect that wasn't the designer's intention).
Related branches
lp:~mbp/launchpad/885972-sendmail-timeline
- William Grant (community): Approve (code)
-
Diff: 281 lines (+147/-11)4 files modifiedlib/lp/services/mail/sendmail.py (+5/-3)
lib/lp/services/mail/tests/test_sendmail.py (+65/-1)
lib/lp/testing/fixture.py (+52/-7)
lib/lp/testing/tests/test_fixture.py (+25/-0)
| summary: |
- ZopeViewReplacementFixture defines tearDown(), but Fixture doesn't care + ZopeViewReplacementFixture.tearDown is never called |
Revision history for this message
| Colin Watson (cjwatson) wrote | #1 |
| Changed in launchpad: | |
| status: | Triaged → Fix Released |
To post a comment you must log in.
mbp fixed this almost a decade ago in a drive-by fix as part of https:/