Launchpad itself

SPPH should dominate other SPPH for same SPR

Bug #845326 reported by Jeroen T. Vermeulen
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Launchpad itself
Fix Released
High
Jeroen T. Vermeulen

Bug Description

This showed up in one spot in soyuz-upload.txt: it looks like if there are multiple published SPPHs for the same SPR in the same archive / series / pocket / package, even if the SPR represents a live version, the newest SPPH should dominate the rest of them.

Similar for BPPH/BPR, of course.

Related branches

lp:~jtv/launchpad/bug-845326
Julian Edwards (community): Approve
Diff: 288 lines (+177/-22)
3 files modified
lib/lp/archivepublisher/domination.py (+19/-4)
lib/lp/archivepublisher/tests/test_dominator.py (+152/-17)
lib/lp/soyuz/model/publishing.py (+6/-1)
Revision history for this message
Launchpad QA Bot (lpqabot) wrote :

Fixed in stable r13911 <http://bazaar.launchpad.net/~launchpad-pqm/launchpad/stable/revision/13911>.

tags: added: qa-needstesting
Changed in launchpad:
status: In Progress → Fix Committed
Revision history for this message
William Grant (wgrant) wrote :

This works fine in archivepublisher... gina I'm not so sure, but the case is very similar.

tags: added: qa-ok
removed: qa-needstesting
William Grant (wgrant)
Changed in launchpad:
status: Fix Committed → Fix Released
Revision history for this message
Jeroen T. Vermeulen (jtv) wrote :

Thanks for testing this, William, and noting the outcome. Yes, in the new domination code the archivepublisher case is the same as the gina case when it comes to multiple publishings of the same release. The reason is that the only information the core domination code gets is the list of active publications and the “live” version string. The caller might have had a specific [BS]PPH in mind, as is the case in publisher domination, but dominatePackage doesn't get that pointed out for it. So it has to make the same decisions in both cases, based on the same information.

To post a comment you must log in.
This report contains Public information  
Everyone can see this information.
Subscribing...

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.