When there is no "Other bug subscribers" incorrect descriptive text is displayed

Bug #837290 reported by Nigel Jones
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Launchpad itself
Fix Released
Undecided
Nigel Jones

Bug Description

When a bug is created (for instance, by a project owner) if nobody other the logged in user is subscribed to the bug, the right hand sidebar ("Other bug subscribers") underneath the "Subscribe someone else" link, will display "No other undefined.".

Apart from been effectively a double-negative it really does make much sense.

An example of how I came across this issue is when I reported https://bugs.launchpad.net/pymheg2xmltv/+bug/836809 to my own project. I've verified that the issue exists in r13822 (current trunk), and I think I have identified a fix, but I wanted to create the bug before discussing it on IRC.

Tags: qa-ok

Related branches

Revision history for this message
Nigel Jones (dev-nigelj) wrote :

I discussed this bug with 'gmb' (Graham Binns) on IRC and am doing a patch that will:

Alter lib/lp/app/javascript/subscribers/subscribers_list.js:SubscribersLoader to merge default values into 'this.config' as well as 'this'.
Add a unit test that reruns 3 of the resetNoSubscribers() tests via SubscribersLoader which will test that merging default values works correctly and produces expected output.

Merge proposal coming soon.

Changed in launchpad:
status: New → In Progress
Revision history for this message
Launchpad QA Bot (lpqabot) wrote :
Changed in launchpad:
assignee: nobody → Nigel Jones (dev-nigelj)
tags: added: qa-needstesting
Changed in launchpad:
status: In Progress → Fix Committed
Revision history for this message
Nigel Jones (dev-nigelj) wrote :

Verified fix on qastaging.

tags: added: qa-ok
removed: qa-needstesting
William Grant (wgrant)
Changed in launchpad:
status: Fix Committed → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.