When there is no "Other bug subscribers" incorrect descriptive text is displayed
Bug #837290 reported by
Nigel Jones
This bug affects 1 person
Affects | Status | Importance | Assigned to | Milestone | |
---|---|---|---|---|---|
Launchpad itself |
Fix Released
|
Undecided
|
Nigel Jones |
Bug Description
When a bug is created (for instance, by a project owner) if nobody other the logged in user is subscribed to the bug, the right hand sidebar ("Other bug subscribers") underneath the "Subscribe someone else" link, will display "No other undefined.".
Apart from been effectively a double-negative it really does make much sense.
An example of how I came across this issue is when I reported https:/
Related branches
lp:~dev-nigelj/launchpad/bug837290
- Graham Binns (community): Approve (code)
-
Diff: 72 lines (+51/-0)2 files modifiedlib/lp/app/javascript/subscribers/subscribers_list.js (+1/-0)
lib/lp/app/javascript/subscribers/tests/test_subscribers_list.js (+50/-0)
Changed in launchpad: | |
status: | Fix Committed → Fix Released |
To post a comment you must log in.
I discussed this bug with 'gmb' (Graham Binns) on IRC and am doing a patch that will:
Alter lib/lp/ app/javascript/ subscribers/ subscribers_ list.js: SubscribersLoad er to merge default values into 'this.config' as well as 'this'. ers() tests via SubscribersLoader which will test that merging default values works correctly and produces expected output.
Add a unit test that reruns 3 of the resetNoSubscrib
Merge proposal coming soon.