DistroSeries:+queue timeout paginating
Bug #835645 reported by
Paul Sladen
This bug affects 3 people
| Affects | Status | Importance | Assigned to | Milestone | |
|---|---|---|---|---|---|
| Launchpad itself |
Fix Released
|
Critical
|
Steve Kowalik | ||
Bug Description
Error ID: OOPS-7c5e4a61c71091cba657e72777464a50
https:/
This is death by late evaluation. The loop iterated 70 times collecting the person, package, and librarian file information. Though each call is cheap, the accumulated are far too slow.
Related branches
lp:~stevenk/launchpad/moar-preload-distroseries-queue
- William Grant: Approve (code)
-
Diff: 568 lines (+139/-84)11 files modifiedlib/lp/security.py (+4/-6)
lib/lp/services/webapp/adapter.py (+0/-4)
lib/lp/soyuz/browser/queue.py (+19/-22)
lib/lp/soyuz/browser/tests/test_queue.py (+23/-2)
lib/lp/soyuz/configure.zcml (+2/-1)
lib/lp/soyuz/model/archive.py (+1/-1)
lib/lp/soyuz/model/binarypackagebuild.py (+1/-1)
lib/lp/soyuz/model/publishing.py (+12/-19)
lib/lp/soyuz/model/queue.py (+60/-21)
lib/lp/soyuz/model/sourcepackagerelease.py (+4/-7)
lib/lp/soyuz/tests/test_packageupload.py (+13/-0)
lp:~stevenk/launchpad/moar-preload-distroseries-queue-redux
- William Grant: Approve (code)
-
Diff: 783 lines (+155/-312)11 files modifiedlib/lp/soyuz/browser/queue.py (+32/-39)
lib/lp/soyuz/browser/tests/test_queue.py (+20/-3)
lib/lp/soyuz/configure.zcml (+1/-13)
lib/lp/soyuz/doc/soyuz-files.txt (+56/-124)
lib/lp/soyuz/interfaces/files.py (+1/-25)
lib/lp/soyuz/interfaces/queue.py (+1/-4)
lib/lp/soyuz/model/files.py (+2/-60)
lib/lp/soyuz/model/queue.py (+27/-13)
lib/lp/soyuz/model/sourcepackagerelease.py (+13/-3)
lib/lp/soyuz/tests/test_binarypackagefile.py (+0/-26)
lib/lp/soyuz/tests/test_packageupload.py (+2/-2)
Revision history for this message
| Robert Collins (lifeless) wrote Re: DistroSeries:+queue timeout with large offset | #1 |
| summary: |
- +queue timesout + DistroSeries:+queue timeout with large offset |
| Changed in launchpad: | |
| status: | New → Triaged |
| importance: | Undecided → Critical |
| tags: | added: timeout |
| summary: |
- DistroSeries:+queue timeout with large offset + DistroSeries:+queue timeout paginating |
| description: | updated |
| tags: | added: lp-soyuz queue-page |
| Changed in launchpad: | |
| status: | Triaged → In Progress |
| assignee: | nobody → Steve Kowalik (stevenk) |
Revision history for this message
| Launchpad QA Bot (lpqabot) wrote | #2 |
| tags: | added: qa-needstesting |
| Changed in launchpad: | |
| status: | In Progress → Fix Committed |
| Changed in launchpad: | |
| status: | Fix Committed → In Progress |
| tags: |
added: qa-ok removed: qa-needstesting |
Revision history for this message
| Launchpad QA Bot (lpqabot) wrote | #3 |
| tags: |
added: qa-needstesting removed: qa-ok |
| Changed in launchpad: | |
| status: | In Progress → Fix Committed |
| tags: |
added: qa-ok removed: qa-needstesting |
| Changed in launchpad: | |
| status: | Fix Committed → Fix Released |
To post a comment you must log in.
This is not a dupe of the performance issue in queue processing - this is a poor batching issue (and so abels work may well help).