Dominate Debian
Bug #832647 reported by
Jeroen T. Vermeulen
This bug affects 1 person
| Affects | Status | Importance | Assigned to | Milestone | |
|---|---|---|---|---|---|
| Launchpad itself |
Fix Released
|
High
|
Jeroen T. Vermeulen | ||
Bug Description
We need to run the Dominator on Debian, probably as part of Gina. Currently all publication records in Debian are incorrectly marked active, and thus the fix for bug 830890 would incorrectly mark them all as deleted.
Related branches
lp:~jtv/launchpad/pre-832647
- William Grant: Approve (code)
-
Diff: 502 lines (+280/-65)5 files modifiedlib/lp/archivepublisher/domination.py (+122/-50)
lib/lp/archivepublisher/tests/test_dominator.py (+150/-2)
lib/lp/soyuz/interfaces/publishing.py (+0/-3)
lib/lp/soyuz/model/publishing.py (+4/-4)
scripts/gina.py (+4/-6)
lp:~jtv/launchpad/bug-832647
- William Grant: Approve (code)
-
Diff: 559 lines (+323/-52)5 files modifiedlib/lp/archivepublisher/domination.py (+103/-13)
lib/lp/archivepublisher/tests/test_dominator.py (+157/-36)
lib/lp/soyuz/scripts/gina/retire.py (+27/-0)
lib/lp/soyuz/scripts/tests/test_gina.py (+31/-3)
scripts/gina.py (+5/-0)
| Changed in launchpad: | |
| assignee: | nobody → Jeroen T. Vermeulen (jtv) |
| status: | Triaged → In Progress |
Revision history for this message
| William Grant (wgrant) wrote | #1 |
Revision history for this message
| Launchpad QA Bot (lpqabot) wrote | #2 |
| tags: | added: qa-needstesting |
| Changed in launchpad: | |
| status: | In Progress → Fix Committed |
| Changed in launchpad: | |
| status: | Fix Committed → In Progress |
| tags: |
added: qa-ok removed: qa-needstesting |
Revision history for this message
| Launchpad QA Bot (lpqabot) wrote | #3 |
| tags: |
added: qa-needstesting removed: qa-ok |
| Changed in launchpad: | |
| status: | In Progress → Fix Committed |
| tags: |
added: qa-ok removed: qa-needstesting |
| Changed in launchpad: | |
| status: | Fix Committed → Fix Released |
To post a comment you must log in.
It's not clear that the archivepublisher dominator is the correct thing here. Debian leaves old sources around until their binaries are gone, so it won't match their behaviour.
I would suggest instead implementing this algorithm, for each active publication:
- Is this version of the package in the parsed indices? If so, terminate, leaving the publication alone.
- Are there any versions of the package in the parsed indices? If so, terminate, marking the publication superseded.
- Mark the publication deleted.