Changing upload/queue admin permissions is broken

Bug #828894 reported by Julian Edwards on 2011-08-18
22
This bug affects 3 people
Affects Status Importance Assigned to Milestone
Launchpad itself
High
Julian Edwards

Bug Description

There are a number of problems in this area:
1. Adding or deleting per-package uploader, component uploader and queue admin permissions require you to be the owner of the main_archive for a distro (for Ubuntu that's ubuntu-archive)
2. Adding or deleting a packageset uploader requires you to be an admin or a member of ubuntu-techboard (hard-coded!)

This is bad because someone who makes a new derived distro cannot change permissions. What we need is:

 * Adding or deleting any permissions tied to the distro owner, which can be easily changed. It's already techboard for Ubuntu and Colin says it's fine to move the operations in #1 above to this new person.

Related branches

Julian Edwards (julian-edwards) wrote :

This is part caused by the insane declaration for IArchivePermissionSet in soyuz/configure.zxcl and part by the security adapter EditArchivePermissionSet (which is currently used for packageset changes as above).

Changed in launchpad:
status: New → Triaged
importance: Undecided → High
tags: added: derivation
Changed in launchpad:
status: Triaged → In Progress
assignee: nobody → Julian Edwards (julian-edwards)
Launchpad QA Bot (lpqabot) wrote :
tags: added: qa-needstesting
Changed in launchpad:
status: In Progress → Fix Committed
William Grant (wgrant) wrote :

newPackagesetUploader and deletePackagesetUploader are on IArchiveView, so anyone can grant themselves privileges.

Rolling back.

tags: added: bad-commit-13755 qa-bad
removed: qa-needstesting
William Grant (wgrant) wrote :

Reverted in r13773.

Changed in launchpad:
status: Fix Committed → In Progress
Julian Edwards (julian-edwards) wrote :

GAH.

Launchpad QA Bot (lpqabot) wrote :
tags: added: qa-needstesting
removed: qa-bad
Changed in launchpad:
status: In Progress → Fix Committed
tags: added: qa-ok
removed: qa-needstesting
William Grant (wgrant) on 2011-08-31
Changed in launchpad:
status: Fix Committed → Fix Released
To post a comment you must log in.
This report contains Public information  Edit
Everyone can see this information.

Duplicates of this bug

Other bug subscribers