rejects package when dpkg-source warns on extraction

[Jelmer Vernooij]

I just had a package rejected by Launchpad because one of the patches in this "3.0 (quilt)" package touched a particular file more than once.

"dpkg-source -x" gives a nice warning about this when uploading a package like this but still completes. Launchpad rejects an upload like this outright, and only sends back a simple error saying that dpkg-source failed with exit code 9.

I also wonder if it's necessary to reject a package in case of a warning like this.

[Julian Edwards (julian-edwards)]

Jelmer, can you attach the upload files you use please? It'll help someone re-create the bug. Thanks!

[Jelmer Vernooij (jelmer)]

I've attached the .dsc and .debian.tar.gz files. The orig tarball is in the archive: https://launchpad.net/ubuntu/+archive/primary/+files/bzr_2.4.0.orig.tar.gz

charis:/tmp% dpkg-source -x bzr_2.4.0-0ubuntu2.dsc
dpkg-source: info: extracting bzr in bzr-2.4.0
dpkg-source: info: unpacking bzr_2.4.0.orig.tar.gz
dpkg-source: info: unpacking bzr_2.4.0-0ubuntu2.debian.tar.gz
dpkg-source: info: applying 01_selftest_package
dpkg-source: info: applying 02_external_configobj
dpkg-source: info: applying 03_external_elementtree
dpkg-source: info: applying 04_fix_i18n
dpkg-source: info: applying 08_selftest_py2.6
dpkg-source: info: applying 10_testtools_compatibility
dpkg-source: warning: diff `bzr-2.4.0/debian/patches/10_testtools_compatibility' patches file bzr-2.4.0/bzrlib/tests/test_selftest.py twice