Requestbuild overlay code swallows error information
Bug #824435 reported by
Henning Eggers
This bug affects 1 person
Affects | Status | Importance | Assigned to | Milestone | |
---|---|---|---|---|---|
Launchpad itself |
Fix Released
|
Critical
|
Henning Eggers |
Bug Description
The code that requests a build in requestbuild_
Related branches
lp:~henninge/launchpad/bug-824435-failure-reporting
- Aaron Bentley (community): Approve
-
Diff: 313 lines (+200/-19)5 files modifiedlib/lp/app/javascript/testing/iorecorder.js (+18/-5)
lib/lp/code/javascript/requestbuild_overlay.js (+34/-13)
lib/lp/code/javascript/tests/test_requestbuild_overlay.html (+38/-0)
lib/lp/code/javascript/tests/test_requestbuild_overlay.js (+104/-0)
lib/lp/code/templates/sourcepackagerecipe-index.pt (+6/-1)
lp:~henninge/launchpad/bug-824435-failure-reporting-2
- Graham Binns (community): Approve (code)
-
Diff: 964 lines (+479/-213)12 files modifiedlib/lp/app/javascript/client.js (+5/-6)
lib/lp/app/javascript/formoverlay/tests/test_formoverlay.js (+10/-15)
lib/lp/app/javascript/picker/tests/test_picker_patcher.js (+20/-31)
lib/lp/app/javascript/testing/iorecorder.js (+0/-60)
lib/lp/app/javascript/testing/mockio.js (+147/-67)
lib/lp/app/javascript/testing/tests/test_mockio.html (+21/-0)
lib/lp/app/javascript/testing/tests/test_mockio.js (+242/-0)
lib/lp/app/javascript/tests/test_lp_client.html (+1/-1)
lib/lp/app/javascript/tests/test_lp_client.js (+14/-12)
lib/lp/code/javascript/requestbuild_overlay.js (+3/-6)
lib/lp/code/javascript/tests/test_requestbuild_overlay.html (+1/-1)
lib/lp/code/javascript/tests/test_requestbuild_overlay.js (+15/-14)
lp:~henninge/launchpad/bug-824435-failure-reporting-3
- Jeroen T. Vermeulen (community): Approve (code)
- Ian Booth (community): Approve (code*)
lp:~henninge/launchpad/bug-824435-failure-reporting-4
- Данило Шеган (community): Approve
-
Diff: 424 lines (+154/-149)3 files modifiedlib/lp/code/browser/sourcepackagerecipe.py (+1/-1)
lib/lp/code/javascript/requestbuild_overlay.js (+130/-132)
lib/lp/code/javascript/tests/test_requestbuild_overlay.js (+23/-16)
tags: |
added: qa-untestable removed: qa-needstesting |
tags: |
added: qa-untestable removed: qa-needstesting |
tags: | added: bad-commit-13766 |
tags: |
added: qa-untestable removed: qa-bad |
tags: |
added: qa-ok removed: qa-needstesting |
tags: |
added: qa-ok removed: qa-needstesting |
Changed in launchpad: | |
status: | Fix Committed → Fix Released |
To post a comment you must log in.
r13744 in stable (http:// bazaar. launchpad. net/~launchpad- pqm/launchpad/ stable/ revision/ 13744) is part of this bug's fix.