Launchpad itself

Requestbuild overlay code swallows error information

Bug #824435 reported by Henning Eggers
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Launchpad itself
Fix Released
Critical
Henning Eggers

Bug Description

The code that requests a build in requestbuild_overlay.js defines a failure handler that will not report the OOPS-ID back. The code in client.js does that, maybe it should be using that code. Without this information bug 812783 cannot be investigated any further.

Related branches

lp:~henninge/launchpad/bug-824435-failure-reporting
Aaron Bentley (community): Approve
Diff: 313 lines (+200/-19)
5 files modified
lib/lp/app/javascript/testing/iorecorder.js (+18/-5)
lib/lp/code/javascript/requestbuild_overlay.js (+34/-13)
lib/lp/code/javascript/tests/test_requestbuild_overlay.html (+38/-0)
lib/lp/code/javascript/tests/test_requestbuild_overlay.js (+104/-0)
lib/lp/code/templates/sourcepackagerecipe-index.pt (+6/-1)
lp:~henninge/launchpad/bug-824435-failure-reporting-2
Graham Binns (community): Approve (code)
Diff: 964 lines (+479/-213)
12 files modified
lib/lp/app/javascript/client.js (+5/-6)
lib/lp/app/javascript/formoverlay/tests/test_formoverlay.js (+10/-15)
lib/lp/app/javascript/picker/tests/test_picker_patcher.js (+20/-31)
lib/lp/app/javascript/testing/iorecorder.js (+0/-60)
lib/lp/app/javascript/testing/mockio.js (+147/-67)
lib/lp/app/javascript/testing/tests/test_mockio.html (+21/-0)
lib/lp/app/javascript/testing/tests/test_mockio.js (+242/-0)
lib/lp/app/javascript/tests/test_lp_client.html (+1/-1)
lib/lp/app/javascript/tests/test_lp_client.js (+14/-12)
lib/lp/code/javascript/requestbuild_overlay.js (+3/-6)
lib/lp/code/javascript/tests/test_requestbuild_overlay.html (+1/-1)
lib/lp/code/javascript/tests/test_requestbuild_overlay.js (+15/-14)
lp:~henninge/launchpad/bug-824435-failure-reporting-3
Jeroen T. Vermeulen (community): Approve (code)
Ian Booth (community): Approve (code*)
lp:~henninge/launchpad/bug-824435-failure-reporting-4
Данило Шеган (community): Approve
Diff: 424 lines (+154/-149)
3 files modified
lib/lp/code/browser/sourcepackagerecipe.py (+1/-1)
lib/lp/code/javascript/requestbuild_overlay.js (+130/-132)
lib/lp/code/javascript/tests/test_requestbuild_overlay.js (+23/-16)
Revision history for this message
Launchpad QA Bot (lpqabot) wrote :

r13744 in stable (http://bazaar.launchpad.net/~launchpad-pqm/launchpad/stable/revision/13744) is part of this bug's fix.

tags: added: qa-needstesting
Henning Eggers (henninge)
tags: added: qa-untestable
removed: qa-needstesting
Revision history for this message
Launchpad QA Bot (lpqabot) wrote :

r13766 in stable (http://bazaar.launchpad.net/~launchpad-pqm/launchpad/stable/revision/13766) is part of this bug's fix.

tags: added: qa-needstesting
removed: qa-untestable
William Grant (wgrant)
tags: added: qa-untestable
removed: qa-needstesting
Revision history for this message
Henning Eggers (henninge) wrote :

I am sorry but I have to block this. I instrumented a function in client.js and in requestbuild_overlay.js and they depend on stuff from lib/lp/app/javascript/teststing/mockio.js. Unfortunately files from the testing directory are not included in launchpad.js which I did not know.

My current branch will move them to lp.client and I hope to be done with that soon. If it needs to be unblocked more quickly, I am happy to extract that move or even revert.

tags: added: qa-bad
removed: qa-untestable
Henning Eggers (henninge)
tags: added: bad-commit-13766
William Grant (wgrant)
tags: added: qa-untestable
removed: qa-bad
Revision history for this message
Launchpad QA Bot (lpqabot) wrote :

r13800 in stable (http://bazaar.launchpad.net/~launchpad-pqm/launchpad/stable/revision/13800) is part of this bug's fix.

tags: added: qa-needstesting
removed: qa-untestable
Henning Eggers (henninge)
tags: added: qa-ok
removed: qa-needstesting
Revision history for this message
Launchpad QA Bot (lpqabot) wrote :

Fixed in stable r13837 <http://bazaar.launchpad.net/~launchpad-pqm/launchpad/stable/revision/13837>.

tags: added: qa-needstesting
removed: qa-ok
Changed in launchpad:
status: In Progress → Fix Committed
Henning Eggers (henninge)
tags: added: qa-ok
removed: qa-needstesting
William Grant (wgrant)
Changed in launchpad:
status: Fix Committed → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.
Subscribing...

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.