privacy ribbon does not appear on bazzar.lp.net

Bug #823471 reported by Curtis Hovey
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Launchpad itself
Fix Released
High
j.c.sackett

Bug Description

lists.launchpad.net and bazaar.launchpad.net do not support the privacy ribbon.

It may be possible to update both MHonArc and Loggerhead to include the prerequisite script and function calls, but both will need rules to include the private css class in the body tag.

    https://launchpad.net/+icing/build/launchpad.js

    <script type="text/javascript">
      LPS.use('base', 'node', 'oop', 'event', function(Y) {
          Y.on("domready", function () {
              if (Y.one(document.body).hasClass('private')) {
                  Y.lp.app.privacy.setup_privacy_notification();
                  Y.lp.app.privacy.display_privacy_notification();
              }
          });
      });
    </script>

Related branches

j.c.sackett (jcsackett)
Changed in launchpad:
assignee: nobody → j.c.sackett (jcsackett)
status: Triaged → In Progress
Revision history for this message
j.c.sackett (jcsackett) wrote :

The original plan Curtis and I discussed involved using lp.client to get the private status of the branch from launchpad via the API. However, for this approach to work, the /api override must exist (e.g. code.launchpad.net/api/) which is not the case for bazaar.launchpad.net.

There is probably a way to add it, but that involves some discussion and is likely a separate bug. I'm taking myself off of this bug until we figure something out (either bazaar.launchpad.net/api/ or another approach).

Changed in launchpad:
assignee: j.c.sackett (jcsackett) → nobody
status: In Progress → Triaged
j.c.sackett (jcsackett)
Changed in launchpad:
assignee: nobody → j.c.sackett (jcsackett)
status: Triaged → In Progress
Revision history for this message
Launchpad QA Bot (lpqabot) wrote :
tags: added: qa-needstesting
Changed in launchpad:
status: In Progress → Fix Committed
Revision history for this message
j.c.sackett (jcsackett) wrote :

This isn't breaking anything, but it's not completely working, either. I've marked it qa-ok and put it back in progress.

tags: added: qa-ok
removed: qa-needstesting
Changed in launchpad:
status: Fix Committed → In Progress
Revision history for this message
Launchpad QA Bot (lpqabot) wrote :
tags: added: qa-needstesting
removed: qa-ok
Changed in launchpad:
status: In Progress → Fix Committed
j.c.sackett (jcsackett)
tags: added: qa-ok
removed: qa-needstesting
Revision history for this message
Curtis Hovey (sinzui) wrote :

We will treat the mailing list archive as a separate bug.

summary: - privacy ribbon does not appear on secondary sites
+ privacy ribbon does not appear on bazzar.lp.net
William Grant (wgrant)
Changed in launchpad:
status: Fix Committed → Fix Released
Curtis Hovey (sinzui)
tags: added: privacy
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.