privacy ribbon does not appear on bazzar.lp.net
Affects | Status | Importance | Assigned to | Milestone | |
---|---|---|---|---|---|
Launchpad itself |
Fix Released
|
High
|
j.c.sackett |
Bug Description
lists.launchpad.net and bazaar.
It may be possible to update both MHonArc and Loggerhead to include the prerequisite script and function calls, but both will need rules to include the private css class in the body tag.
https:/
<script type="text/
LPS.
if (Y.one(
}
});
});
</script>
Related branches
- John A Meinel: Approve
- Ian Booth (community): Approve (code)
-
Diff: 236 lines (+165/-5)5 files modifiedloggerhead/apps/branch.py (+8/-1)
loggerhead/static/css/global.css (+61/-0)
loggerhead/static/javascript/custom.js (+87/-1)
loggerhead/templates/macros.pt (+1/-1)
loggerhead/tests/test_simple.py (+8/-2)
- Gavin Panella (community): Approve (code)
- Raphaël Badin (community): Approve (code*)
-
Diff: 68 lines (+24/-2)2 files modifiedlib/launchpad_loggerhead/app.py (+23/-1)
utilities/sourcedeps.conf (+1/-1)
- Curtis Hovey (community): Approve (code)
-
Diff: 42 lines (+13/-6)1 file modifiedlib/launchpad_loggerhead/app.py (+13/-6)
Changed in launchpad: | |
assignee: | nobody → j.c.sackett (jcsackett) |
status: | Triaged → In Progress |
Changed in launchpad: | |
assignee: | nobody → j.c.sackett (jcsackett) |
status: | Triaged → In Progress |
tags: |
added: qa-ok removed: qa-needstesting |
Changed in launchpad: | |
status: | Fix Committed → Fix Released |
tags: | added: privacy |
The original plan Curtis and I discussed involved using lp.client to get the private status of the branch from launchpad via the API. However, for this approach to work, the /api override must exist (e.g. code.launchpad. net/api/ ) which is not the case for bazaar. launchpad. net.
There is probably a way to add it, but that involves some discussion and is likely a separate bug. I'm taking myself off of this bug until we figure something out (either bazaar. launchpad. net/api/ or another approach).