Hidden comments expander fails with out-of-order emails ("-1 comments hidden")
Bug #818456 reported by
Paul Sladen
This bug affects 1 person
| Affects | Status | Importance | Assigned to | Milestone | |
|---|---|---|---|---|---|
| Launchpad itself |
Fix Released
|
Critical
|
j.c.sackett | ||
Bug Description
In a bug with both:
(a) out-of-order emailed comments
(b) hidden comments (spam, vacation messages)
then Launchpad can print:
"-1 comments hidden … view all NNN comments"
what probably should happen:
(1) nothing is displayed in the case that the comments are hidden-hidden (as is the case here—clicking "view all" will not show them either)
(2) a positive integer number of comments is displayed, reflecting what would be shown if the box is expanded
An example of the issue can be seen in bug #629258, although this may change change as more vacation messages are cleared up; in which case see the attached screenshot.
Related branches
lp:~jcsackett/launchpad/hidden-comment-count-error
- Richard Harding (community): Approve
-
Diff: 96 lines (+67/-1)2 files modifiedlib/lp/bugs/browser/bugtask.py (+6/-1)
lib/lp/bugs/browser/tests/test_bugtask.py (+61/-0)
Revision history for this message
| Paul Sladen (sladen) wrote | #1 |
| Changed in launchpad: | |
| status: | New → Triaged |
| importance: | Undecided → High |
| tags: | added: bugs comments |
| tags: | added: regression |
| Changed in launchpad: | |
| importance: | High → Critical |
| assignee: | nobody → Graham Binns (gmb) |
| Changed in launchpad: | |
| assignee: | Graham Binns (gmb) → nobody |
| tags: | added: disclosure |
| tags: | added: information-type |
| Changed in launchpad: | |
| assignee: | nobody → j.c.sackett (jcsackett) |
| Changed in launchpad: | |
| status: | Triaged → In Progress |
Revision history for this message
| Launchpad QA Bot (lpqabot) wrote | #2 |
| tags: | added: qa-needstesting |
| Changed in launchpad: | |
| status: | In Progress → Fix Committed |
| tags: |
added: qa-ok removed: qa-needstesting |
| Changed in launchpad: | |
| status: | Fix Committed → Fix Released |
To post a comment you must log in.
Fixed in stable r15599 <http://