Hidden comments expander fails with out-of-order emails ("-1 comments hidden")

Bug #818456 reported by Paul Sladen on 2011-07-30
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Launchpad itself

Bug Description

In a bug with both:

  (a) out-of-order emailed comments
  (b) hidden comments (spam, vacation messages)

then Launchpad can print:

  "-1 comments hidden … view all NNN comments"

what probably should happen:

  (1) nothing is displayed in the case that the comments are hidden-hidden (as is the case here—clicking "view all" will not show them either)
  (2) a positive integer number of comments is displayed, reflecting what would be shown if the box is expanded

An example of the issue can be seen in bug #629258, although this may change change as more vacation messages are cleared up; in which case see the attached screenshot.

Related branches

Paul Sladen (sladen) wrote :
Aaron Bentley (abentley) on 2011-08-01
Changed in launchpad:
status: New → Triaged
importance: Undecided → High
Curtis Hovey (sinzui) on 2011-11-16
tags: added: bugs comments
Curtis Hovey (sinzui) on 2011-11-22
tags: added: regression
Changed in launchpad:
importance: High → Critical
assignee: nobody → Graham Binns (gmb)
Graham Binns (gmb) on 2011-12-15
Changed in launchpad:
assignee: Graham Binns (gmb) → nobody
Curtis Hovey (sinzui) on 2012-07-02
tags: added: disclosure
tags: added: information-type
j.c.sackett (jcsackett) on 2012-07-02
Changed in launchpad:
assignee: nobody → j.c.sackett (jcsackett)
j.c.sackett (jcsackett) on 2012-07-02
Changed in launchpad:
status: Triaged → In Progress
Launchpad QA Bot (lpqabot) wrote :
tags: added: qa-needstesting
Changed in launchpad:
status: In Progress → Fix Committed
j.c.sackett (jcsackett) on 2012-07-11
tags: added: qa-ok
removed: qa-needstesting
William Grant (wgrant) on 2012-07-13
Changed in launchpad:
status: Fix Committed → Fix Released
To post a comment you must log in.
This report contains Public information  Edit
Everyone can see this information.

Other bug subscribers