Need extra round-trip to create a private PPA via webservice
Bug #814567 reported by
Jonathan Lange
This bug affects 1 person
| Affects | Status | Importance | Assigned to | Milestone | |
|---|---|---|---|---|---|
| Launchpad itself |
Fix Released
|
High
|
Jonathan Lange | ||
Bug Description
To create a private PPA via the webservice, you need to do something like this::
ppa = person.
ppa.private = True
ppa.lp_save()
This is an extra round-trip on top of creating a public PPA.
It also means that:
1. for a short period of time, the created PPA is public
2. if you don't have permission to create a private PPA, then you have created a public PPA
Probably createPPA should take a 'private' parameter.
Related branches
lp:~jml/launchpad/create-private-ppa-814567
- Julian Edwards (community): Approve
-
Diff: 173 lines (+80/-8)6 files modifiedlib/lp/registry/interfaces/person.py (+6/-2)
lib/lp/registry/model/person.py (+4/-4)
lib/lp/soyuz/configure.zcml (+6/-0)
lib/lp/soyuz/model/archive.py (+11/-1)
lib/lp/soyuz/stories/webservice/xx-person-createppa.txt (+28/-0)
lib/lp/soyuz/tests/test_archive.py (+25/-1)
lp:~jml/launchpad/create-private-ppa-814567-2
- Henning Eggers (community): Approve
-
Diff: 116 lines (+44/-4)5 files modifiedlib/lp/registry/model/person.py (+1/-1)
lib/lp/soyuz/interfaces/archive.py (+3/-1)
lib/lp/soyuz/model/archive.py (+3/-1)
lib/lp/soyuz/stories/webservice/xx-person-createppa.txt (+36/-0)
lib/lp/soyuz/tests/test_archive.py (+1/-1)
| description: | updated |
Revision history for this message
| Jonathan Lange (jml) wrote | #1 |
| Changed in launchpad: | |
| status: | New → Triaged |
| importance: | Undecided → High |
| Changed in launchpad: | |
| status: | Triaged → In Progress |
| assignee: | nobody → Jonathan Lange (jml) |
Revision history for this message
| Launchpad QA Bot (lpqabot) wrote | #2 |
| tags: | added: qa-needstesting |
| Changed in launchpad: | |
| status: | In Progress → Fix Committed |
Revision history for this message
| Steve Kowalik (stevenk) wrote | #3 |
| tags: |
added: qa-ok removed: qa-needstesting |
| Changed in launchpad: | |
| status: | Fix Committed → Triaged |
Revision history for this message
| Launchpad QA Bot (lpqabot) wrote | #4 |
| tags: |
added: qa-needstesting removed: qa-ok |
| Changed in launchpad: | |
| status: | Triaged → Fix Committed |
| tags: |
added: qa-ok removed: qa-needstesting |
| Changed in launchpad: | |
| status: | Fix Committed → Fix Released |
To post a comment you must log in.
Exacerbated by bug 814633.