hard to get from mp to per-revision diffs
Bug #813349 reported by
Martin Pool
This bug affects 1 person
Affects | Status | Importance | Assigned to | Milestone | |
---|---|---|---|---|---|
Launchpad itself |
Triaged
|
High
|
Unassigned |
Bug Description
It would be more useful if you could review individual mp component diffs inline.
This is now done, but it does not work for private branches (bug 806713).
Related branches
lp:~spiv/launchpad/bmp-inline-diffs
- Данило Шеган (community): Approve
-
Diff: 418 lines (+333/-2)8 files modifiedlib/lp/code/browser/branchmergeproposal.py (+11/-0)
lib/lp/code/javascript/branch.revisionexpander.js (+103/-0)
lib/lp/code/javascript/tests/test_branchrevisionexpander.html (+35/-0)
lib/lp/code/javascript/tests/test_branchrevisionexpander.js (+151/-0)
lib/lp/code/templates/branch-macros.pt (+16/-0)
lib/lp/code/templates/branchmergeproposal-index.pt (+11/-1)
lib/lp/code/templates/codereviewnewrevisions-footer.pt (+2/-1)
lib/lp/services/features/flags.py (+4/-0)
description: | updated |
Changed in launchpad: | |
status: | Fix Committed → In Progress |
Changed in launchpad: | |
assignee: | Andrew Bennetts (spiv) → Martin Pool (mbp) |
Changed in launchpad: | |
assignee: | Martin Pool (mbp) → nobody |
status: | In Progress → Triaged |
To post a comment you must log in.
poolie: if it deploys i will have poke at it for you
spiv: Thanks! The main thing for QA I think is to see that without the feature flag it doesn't break the branch merge proposal page (I'm sure it'll be fine),
spiv: and then if the feature flag is set (maybe just for canonifolk or beta-testers?) that the expanders exist and work on that page.