launchpad should mark required sreg attributes as required

[Ricardo Kirkner]

We're releasing a feature to allow end-users to decide which attributes to share with the consumer site (see bug #121533).
While testing this on staging, we found that the username and email sreg attributes, while marked as optional result in an oops (bug #810623) if not provided. They should probably be marked as required.

[Francis J. Lacoste (flacoste)]

Escalated by ISD because they are waiting on us to fix this to deploy their new version.

[Launchpad QA Bot (lpqabot)]

Fixed in stable r13441 <http://bazaar.launchpad.net/~launchpad-pqm/launchpad/stable/revision/13441>.

[Michael Nelson (michael.nelson)]

Ricardo - I'm guessing you guys haven't checked any ISD apps against staging SSO, as afaics, django-openid-auth also uses optional sreg attributes only (and we use it for all our apps). I've created bug 810978 to track that.

[Robert Collins (lifeless)]

Sounds like perhaps we should treat optional as required for
trusted/internal sites, as a migration facility.

[Stuart Metcalfe (stuartmetcalfe)]

Agreed. We'll get this done before the production deployment.