comments on bugs/answers/merge proposals/etc cannot be edited
Affects | Status | Importance | Assigned to | Milestone | |
---|---|---|---|---|---|
Launchpad itself |
Fix Released
|
Low
|
Thiago F. Pappacena |
Bug Description
Occasionally in bug reports, people stuff up and make comments that are bad. They're factually wrong, or they're horribly misworded, or they insult someone badly, or a combination of those. To some extent the damage can be repaired in a later comment, but that's even more noise. So it would be really nifty if people could edit or delete their comments.
This wouldn't be effective if we were sending out immediate e-mail notifications of each comment, but we're not. We're already waiting for five minutes after the comment, in case something else happens so that we can send a batched notification. So we can give someone that five minutes to edit/delete their comment. If it was edited, the mail notification would contain only the final version; if it was deleted, there would be no notification at all.
While this would lead to more harmonious discussions, it would also need thorough specification of the corner cases. For example:
- If someone tries to submit an edit/deletion after the five minutes, they should get an error, with their edited text (if any) pre-filled as the basis of a new comment.
- If a comment changes or is deleted between the time someone else opens the bug report and the time they submit their own comment, Launchpad should warn them and give them a chance to adjust their own comment in response.
For editing or deleting someone else's comment, see bug 668267.
Related branches
- Colin Watson: Approve
-
Diff: 326 lines (+147/-17)7 files modifiedlib/canonical/launchpad/icing/css/base.scss (+7/-0)
lib/lp/answers/templates/questionmessage-display.pt (+5/-1)
lib/lp/bugs/templates/bugcomment-box.pt (+5/-2)
lib/lp/code/templates/codereviewcomment-header.pt (+3/-0)
lib/lp/services/messages/javascript/messages.edit.js (+63/-4)
lib/lp/services/messages/javascript/tests/test_messages.edit.html (+8/-2)
lib/lp/services/messages/javascript/tests/test_messages.edit.js (+56/-8)
- Colin Watson: Approve
-
Diff: 268 lines (+148/-4)6 files modifiedlib/lp/answers/templates/questionmessage-display.pt (+4/-0)
lib/lp/bugs/templates/bugcomment-box.pt (+4/-1)
lib/lp/code/templates/codereviewcomment-header.pt (+4/-1)
lib/lp/services/messages/javascript/messages.edit.js (+79/-1)
lib/lp/services/messages/javascript/tests/test_messages.edit.html (+2/-0)
lib/lp/services/messages/javascript/tests/test_messages.edit.js (+55/-1)
- Launchpad code reviewers: Pending requested
-
Diff: 161 lines (+79/-5)3 files modifiedlib/canonical/launchpad/icing/css/base.scss (+7/-0)
lib/lp/answers/templates/questionmessage-display.pt (+5/-1)
lib/lp/services/messages/javascript/messages.edit.js (+67/-4)
- Colin Watson: Approve
-
Diff: 73 lines (+25/-2)2 files modifiedlib/lp/code/stories/branches/xx-code-review-comments.txt (+3/-0)
lib/lp/code/templates/codereviewcomment-header.pt (+22/-2)
- Colin Watson: Approve
-
Diff: 173 lines (+37/-5)5 files modifiedlib/lp/bugs/stories/bugattachments/xx-attachments-to-bug-report.txt (+2/-0)
lib/lp/bugs/stories/bugs/xx-bug-activity.txt (+5/-0)
lib/lp/bugs/stories/bugs/xx-bug-create-question.txt (+1/-0)
lib/lp/bugs/stories/bugs/xx-remote-bug-comments.txt (+4/-1)
lib/lp/bugs/templates/bugcomment-box.pt (+25/-4)
- Colin Watson: Approve
-
Diff: 540 lines (+318/-27)8 files modifiedlib/canonical/launchpad/icing/css/base.scss (+55/-0)
lib/lp/answers/browser/question.py (+1/-3)
lib/lp/answers/stories/question-workflow.txt (+1/-1)
lib/lp/answers/templates/questionmessage-display.pt (+22/-2)
lib/lp/services/messages/interfaces/messagerevision.py (+2/-1)
lib/lp/services/messages/javascript/messages.edit.js (+103/-18)
lib/lp/services/messages/javascript/tests/test_messages.edit.html (+58/-1)
lib/lp/services/messages/javascript/tests/test_messages.edit.js (+76/-1)
- Colin Watson: Approve
-
Diff: 145 lines (+29/-8)6 files modifiedlib/lp/code/browser/codereviewcomment.py (+5/-0)
lib/lp/code/browser/tests/test_branchmergeproposal.py (+3/-1)
lib/lp/code/stories/branches/xx-code-review-comments.txt (+4/-4)
lib/lp/code/templates/branchmergeproposal-index.pt (+3/-1)
lib/lp/code/templates/codereviewcomment-header.pt (+12/-1)
lib/lp/services/comments/templates/comment.pt (+2/-1)
- Colin Watson: Approve
-
Diff: 470 lines (+145/-55)14 files modifiedlib/lp/bugs/browser/bugcomment.py (+9/-0)
lib/lp/bugs/stories/bugattachments/xx-delete-bug-attachment.txt (+14/-4)
lib/lp/bugs/stories/bugs/xx-add-comment-bugtask-edit.txt (+1/-1)
lib/lp/bugs/stories/bugs/xx-add-comment-distribution-no-current-release.txt (+1/-1)
lib/lp/bugs/stories/bugs/xx-bug-activity.txt (+4/-0)
lib/lp/bugs/stories/bugs/xx-bug-comments-truncated.txt (+35/-12)
lib/lp/bugs/stories/bugs/xx-bug-create-question.txt (+1/-1)
lib/lp/bugs/stories/bugs/xx-bug-hidden-comments.txt (+4/-4)
lib/lp/bugs/stories/bugwatches/xx-bugwatch-comments.txt (+28/-16)
lib/lp/bugs/stories/guided-filebug/xx-bug-reporting-tools.txt (+3/-2)
lib/lp/bugs/templates/bugcomment-box.pt (+22/-4)
lib/lp/bugs/templates/bugtask-index.pt (+3/-1)
lib/lp/services/comments/templates/comment-body.pt (+18/-7)
lib/lp/services/messages/javascript/tests/test_messages.edit.html (+2/-2)
- Colin Watson: Approve
-
Diff: 754 lines (+593/-19)10 files modifiedlib/canonical/launchpad/icing/css/base.scss (+40/-2)
lib/lp/answers/browser/question.py (+6/-0)
lib/lp/answers/stories/question-workflow.txt (+7/-6)
lib/lp/answers/templates/question-index.pt (+3/-1)
lib/lp/answers/templates/questionmessage-display.pt (+29/-9)
lib/lp/services/messages/interfaces/message.py (+1/-1)
lib/lp/services/messages/javascript/messages.edit.js (+211/-0)
lib/lp/services/messages/javascript/tests/test_messages.edit.html (+95/-0)
lib/lp/services/messages/javascript/tests/test_messages.edit.js (+175/-0)
lib/lp/services/messages/tests/test_yuitests.py (+26/-0)
- Colin Watson: Approve
-
Diff: 746 lines (+328/-54)21 files modifiedlib/lp/_schema_circular_imports.py (+2/-0)
lib/lp/answers/browser/configure.zcml (+4/-0)
lib/lp/answers/browser/question.py (+15/-0)
lib/lp/answers/stories/webservice.txt (+1/-0)
lib/lp/bugs/browser/bugcomment.py (+15/-0)
lib/lp/bugs/browser/configure.zcml (+5/-1)
lib/lp/code/browser/codereviewcomment.py (+15/-0)
lib/lp/code/browser/configure.zcml (+4/-1)
lib/lp/code/stories/webservice/xx-branchmergeproposal.txt (+3/-0)
lib/lp/services/messages/browser/configure.zcml (+10/-0)
lib/lp/services/messages/browser/message.py (+4/-0)
lib/lp/services/messages/configure.zcml (+1/-0)
lib/lp/services/messages/interfaces/message.py (+11/-1)
lib/lp/services/messages/interfaces/messagerevision.py (+20/-6)
lib/lp/services/messages/interfaces/webservice.py (+3/-1)
lib/lp/services/messages/model/message.py (+11/-4)
lib/lp/services/messages/model/messagerevision.py (+21/-0)
lib/lp/services/messages/tests/scenarios.py (+41/-0)
lib/lp/services/messages/tests/test_message.py (+16/-35)
lib/lp/services/messages/tests/test_messagerevision.py (+120/-5)
lib/lp/services/webservice/wadl-to-refhtml.xsl (+6/-0)
description: | updated |
Changed in malone: | |
status: | New → Confirmed |
Changed in launchpad-answers: | |
importance: | Undecided → Low |
status: | New → Triaged |
tags: | added: feature |
description: | updated |
description: | updated |
actually it should not just be 5 minutes it should be more than tht, it should be something like an hr. or so or even indefinitely. If a person does make a change, the e-mail could be re-sent with the original & the change. I have seen these kinds of mails & do like tht. There have been bugs which I have put up to realize l8ter they should have been worded differently or i was plain wrong, X happened due to Y but I did not know about Y at the time I reported the bug. Later I understood or came to know about Y but now I cannot edit my first post to reflect it. For an e.g. I reproduce the bug which I reported at https:/ /bugs.launchpad .net/ubuntu/ +source/ pkgsel/ +bug/99303