person picker could have a link to choose myself when I am a valid choice
Bug #787595 reported by
Curtis Hovey
This bug affects 1 person
| Affects | Status | Importance | Assigned to | Milestone | |
|---|---|---|---|---|---|
| Launchpad itself |
Fix Released
|
High
|
j.c.sackett | ||
Bug Description
The bugtask assignee widget allows me to choose myself. While investigating person picker timeouts, I saw that users were searching for themselves. The person picker could have a link to choose myself when I am a valid choice:
ValidPerson
ValidPerson
ValidPerson
ValidTeamMember
ValidTeamOwner
Related branches
lp:~jcsackett/launchpad/oh-oh-pick-me-pick-me
- Steve Kowalik (community): Approve (code)
-
Diff: 215 lines (+181/-2)4 files modifiedlib/lp/app/widgets/popup.py (+1/-2)
lib/lp/registry/javascript/personpicker.js (+74/-0)
lib/lp/registry/javascript/tests/test_personpicker.html (+40/-0)
lib/lp/registry/javascript/tests/test_personpicker.js (+66/-0)
lp:~jcsackett/launchpad/oh-oh-pick-me-pick-me-2
- Curtis Hovey (community): Approve (code + ui)
-
Diff: 366 lines (+110/-89)7 files modifiedlib/canonical/launchpad/webapp/configure.zcml (+2/-2)
lib/lp/app/javascript/picker.js (+12/-43)
lib/lp/app/javascript/tests/test_personpicker.html (+1/-1)
lib/lp/app/javascript/tests/test_personpicker.js (+9/-9)
lib/lp/app/javascript/widgets.js (+71/-32)
lib/lp/app/widgets/popup.py (+13/-1)
lib/lp/app/widgets/templates/form-picker-macros.pt (+2/-1)
lp:~henninge/launchpad/bug-410864-undefined-in-picker
- Curtis Hovey (community): Approve (code)
-
Diff: 472 lines (+155/-94)9 files modifiedlib/canonical/launchpad/webapp/configure.zcml (+2/-2)
lib/lp/app/javascript/picker.js (+21/-44)
lib/lp/app/javascript/tests/test_personpicker.html (+1/-1)
lib/lp/app/javascript/tests/test_personpicker.js (+4/-4)
lib/lp/app/javascript/tests/test_picker.html (+1/-0)
lib/lp/app/javascript/tests/test_picker.js (+36/-9)
lib/lp/app/javascript/widgets.js (+75/-32)
lib/lp/app/widgets/popup.py (+13/-1)
lib/lp/app/widgets/templates/form-picker-macros.pt (+2/-1)
| Changed in launchpad: | |
| assignee: | nobody → j.c.sackett (jcsackett) |
| Changed in launchpad: | |
| status: | Triaged → In Progress |
Revision history for this message
| Launchpad QA Bot (lpqabot) wrote | #1 |
| tags: | added: qa-needstesting |
| Changed in launchpad: | |
| status: | In Progress → Fix Committed |
| Changed in launchpad: | |
| status: | Fix Committed → In Progress |
| tags: |
added: qa-untestable removed: qa-needstesting |
| security vulnerability: | no → yes |
| security vulnerability: | yes → no |
Revision history for this message
| Launchpad QA Bot (lpqabot) wrote | #2 |
| tags: |
added: qa-needstesting removed: qa-untestable |
| Changed in launchpad: | |
| status: | In Progress → Fix Committed |
| tags: |
added: qa-ok removed: qa-needstesting |
| Changed in launchpad: | |
| status: | Fix Committed → Fix Released |
To post a comment you must log in.
Fixed in stable r13149 <http://