Muting a bug subscription for a team with a contact address crashes getRecipientFilterData

[William Grant]

getRecipientFilterData crashes if it finds a BugSubscriptionFilterMute for a person who isn't receiving an email through that filter. This has only shown itself once on production so far: people muted ~launchpad-bugs' subscription to launchpad when it had no contact address, but then it had its contact address readded. This meant that only the team itself received notifications from that filter, so all the mutes were redundant and crashy.

Steps to reproduce locally:
 1) Create a team with a contact address.
 2) Subscribe that team to a project's bugs.
 3) As a member of that team, mute the structural subscription.
 4) File a bug on the project.
 5) After 5 minutes (or whatever the notification batching window is), run send-bug-notifications.py.
 6) OOPS-1952REPORTIFSEEN1000 (http://launchpadlibrarian.net/71237712/mxcMwtvbHTEmUeoQItq4WoPvjt.txt)

[Tom Haddon (mthaddon)]

Not sure if this is related, but it also looks like the bug subscriptions aren't being added for newly created bugs - I just created bug 779406 but no-one was subscribed by default, when normally I'd expect at least ~launchpad to be subscribed.

[William Grant (wgrant)]

Tom, that's just a display issue. It seems to be a deliberate change from the advanced subscriptions work -- see bug #768483.

[Robert Collins (lifeless)]

This was incomplete new functionality vs breaking 'released' functionality - untagging regression from it.

[Robert Collins (lifeless)]

Ok, retagging - once a recipient was affecting, all notifications on the same bug halted.

[Launchpad QA Bot (lpqabot)]

Fixed in stable r13096 <http://bazaar.launchpad.net/~launchpad-pqm/launchpad/stable/revision/13096>.