mail headers inconsistent between package and recipe builds

[Vincent Ladeuil]

Mails sent by buildd doesn't contain the same headers depending on whether the build failed to build or to upload. This makes it harder to properly filter them (not such a big deal but it would be nice if the same informations were available in both mails):

FAILEDTOBUILD:

Content-Type: text/plain; charset="utf-8"
MIME-Version: 1.0
Content-Transfer-Encoding: quoted-printable
X-Launchpad-PPA: bzr-proposed
X-Launchpad-Build-Arch: amd64
X-Launchpad-Build-Component: main
X-Creator-Recipient: <email address hidden>
X-Launchpad-Build-State: FAILEDTOBUILD
Message-Id: <email address hidden>
Date: Thu, 17 Mar 2011 08:31:38 -0000
Reply-To: Launchpad Buildd System <email address hidden>
Sender: <email address hidden>
Errors-To: <email address hidden>
Precedence: bulk
X-Generated-By: Launchpad (canonical.com); Revision="12611"; Instance="initZopeless config overlay"
X-Launchpad-Hash: 7e4c991fab0ce87830a9565540a5c680fcf4e983
Lines: 23

FAILEDTOUPLOAD (similar to FULLYBUILT !):

Content-Type: text/plain; charset="utf-8"
MIME-Version: 1.0
Content-Transfer-Encoding: quoted-printable
X-Launchpad-Build-State: FAILEDTOUPLOAD
X-Launchpad-Message-Rationale: Requester @bzr
X-Launchpad-Notification-Type: recipe-build-status
Message-Id: <email address hidden>
Date: Wed, 30 Mar 2011 23:47:14 -0000
Reply-To: <email address hidden>
Sender: <email address hidden>
Errors-To: <email address hidden>
Precedence: bulk
X-Generated-By: Launchpad (canonical.com); Revision="12684"; Instance="initZopeless config overlay"
X-Launchpad-Hash: 9023516e950cd91db56ee28e8a40ba74710f28f8
Lines: 15

At least X-Launchpad-PPA and X-Launchpad-Notification-Type may be nice to find in both (but feel free to add more ;)

[Colin Watson (cjwatson)]

This is mostly fixed now that BinaryPackageBuild uses BaseMailer. The remaining piece is that recipe build notifications should gain X-Launchpad-Archive with a reference to the build archive (similar to X-Launchpad-PPA, but not legacy).

[Launchpad QA Bot (lpqabot)]

Fixed in stable r17696 <http://bazaar.launchpad.net/~launchpad-pqm/launchpad/stable/revision/17696>.