batch navigation uses high OFFSET rather than db constraints
Bug #752153 reported by
Robert Collins
This bug affects 1 person
| Affects | Status | Importance | Assigned to | Milestone | |
|---|---|---|---|---|---|
| Launchpad itself |
Fix Released
|
Critical
|
Steve Kowalik | ||
Bug Description
This leads to timeouts where materialising the query is expensive, but doing a > (or <) clause in the query would dramatically reduce the database work and let us support greater offsets happily.
Related branches
lp:~lifeless/launchpad/bug-752153
- Steve Kowalik (community): Approve (code)
-
Diff: 247 lines (+22/-102)8 files modifiedlib/canonical/launchpad/doc/batch_navigation.txt (+4/-74)
lib/lp/app/browser/root.py (+12/-20)
lib/lp/app/browser/tests/launchpad-search-pages.txt (+0/-2)
lib/lp/bugs/stories/webservice/xx-bug-tracker.txt (+1/-1)
lib/lp/bugs/stories/webservice/xx-bug.txt (+2/-2)
lib/lp/services/features/browser/tests/test_changelog.py (+1/-1)
lib/lp/translations/browser/tests/pofile-views.txt (+1/-1)
versions.cfg (+1/-1)
Revision history for this message
| Robert Collins (lifeless) wrote | #1 |
| Changed in launchpad: | |
| assignee: | nobody → Robert Collins (lifeless) |
Revision history for this message
| Launchpad QA Bot (lpqabot) wrote | #2 |
| Changed in launchpad: | |
| milestone: | none → 11.05 |
| tags: | added: qa-needstesting |
| Changed in launchpad: | |
| status: | Triaged → Fix Committed |
| tags: |
added: bad-commit-12805 qa-bad removed: qa-needstesting |
| Changed in launchpad: | |
| status: | Fix Committed → Fix Released |
| Changed in launchpad: | |
| status: | Fix Released → Triaged |
| milestone: | 11.05 → none |
| tags: | removed: qa-bad |
Revision history for this message
| Robert Collins (lifeless) wrote | #3 |
| Changed in launchpad: | |
| assignee: | Robert Collins (lifeless) → nobody |
Revision history for this message
| Ian Booth (wallyworld) wrote | #4 |
| Changed in launchpad: | |
| assignee: | nobody → Steve Kowalik (stevenk) |
| status: | Triaged → Fix Released |
To post a comment you must log in.
I had some test failures - we have tests which encode the generated urls (that the new version changes); I'll work through that in the next few days.