Launchpad itself

BugTask:+index times out with lots of attachments

Bug #750949 reported by William Grant
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Launchpad itself
Fix Released
Critical
William Grant
Launchpad itself 11.05

Bug Description

BugTask:+index can make lots of queries for LibraryFileContents, as seen in OOPS-1920A1682. This seems to occur if many attachments are being shown in comments, as the template shows LFC.filesize. Only the LFAs are preloaded for the portlet.

https://bugs.launchpad.net/ubuntu/+source/xorg-server/+bug/312756?comments=all
OOPS-1923K247

See original description

Related branches

lp:~wgrant/launchpad/bug-750949
Robert Collins (community): Approve
Diff: 124 lines (+41/-7)
4 files modified
lib/canonical/launchpad/webapp/publication.py (+2/-0)
lib/lp/bugs/browser/bugattachment.py (+3/-0)
lib/lp/bugs/browser/tests/test_bugtask.py (+28/-3)
lib/lp/bugs/model/bug.py (+8/-4)
Revision history for this message
Launchpad QA Bot (lpqabot) wrote :

Fixed in stable r12748 <http://bazaar.launchpad.net/~launchpad-pqm/launchpad/stable/revision/12748>.

Changed in launchpad:
milestone: none → 11.04
tags: added: qa-needstesting
Changed in launchpad:
status: In Progress → Fix Committed
William Grant (wgrant)
tags: added: qa-ok
removed: qa-needstesting
William Grant (wgrant)
tags: added: qa-needstesting
removed: qa-ok
Revision history for this message
William Grant (wgrant) wrote :

The bug times out on qas, but due to multi-second gaps before the new query is reached. Less hideous bugs work fine.

tags: added: qa-ok
removed: qa-needstesting
William Grant (wgrant)
Changed in launchpad:
milestone: 11.04 → 11.05
William Grant (wgrant)
Changed in launchpad:
status: Fix Committed → Fix Released
Revision history for this message
Robert Collins (lifeless) wrote :

Possibly not fixed; the oops I attached needs a review to see whats slow.

description: updated
Changed in launchpad:
status: Fix Released → Triaged
tags: removed: qa-ok
Revision history for this message
William Grant (wgrant) wrote :

It renders in 8-9s now. The OOPS was from a multi-threaded wampee instance, so it will be irrelevant soon.

Changed in launchpad:
status: Triaged → Fix Released
Francis J. Lacoste (flacoste)
tags: added: critical-analysis
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.
Subscribing...

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.