only commercial admins can setup branch privacy policies
Bug #750871 reported by
Martin Pool
This bug affects 2 people
| Affects | Status | Importance | Assigned to | Milestone | |
|---|---|---|---|---|---|
| Launchpad itself |
Fix Released
|
High
|
William Grant | ||
Bug Description
Projects have a branch privacy policy that says whether branches are public or private by default and whether they can be public or private. (I think.) At the moment this can only be changed by losas. It would be better if there was a ui and api for allowing project owners to read this and change it. There are some business rules about who is entitled to set particular values.
This causes a lot of latency for new users and a fair amount of work for feedback@, commercial@ and losas, on which grounds Robert says this can probably be critical.
Related branches
lp:~wgrant/launchpad/branchnamespace-information-type
- Curtis Hovey (community): Approve (code)
-
Diff: 696 lines (+137/-287)6 files modifiedlib/lp/code/errors.py (+0/-10)
lib/lp/code/interfaces/branchnamespace.py (+6/-16)
lib/lp/code/model/branch.py (+6/-9)
lib/lp/code/model/branchnamespace.py (+52/-76)
lib/lp/code/model/tests/test_branch.py (+5/-6)
lib/lp/code/model/tests/test_branchnamespace.py (+68/-170)
lp:~wgrant/launchpad/more-branchnamespace
- Ian Booth (community): Approve
-
Diff: 189 lines (+61/-40)5 files modifiedlib/lp/code/browser/branchlisting.py (+25/-6)
lib/lp/code/browser/tests/test_product.py (+13/-7)
lib/lp/code/interfaces/branchnamespace.py (+4/-6)
lib/lp/code/model/branchnamespace.py (+5/-8)
lib/lp/code/templates/product-branches.pt (+14/-13)
lp:~wgrant/launchpad/improve-branch-edit-type
- j.c.sackett (community): Approve
-
Diff: 531 lines (+185/-228)5 files modifiedlib/lp/code/browser/branch.py (+50/-25)
lib/lp/code/browser/tests/test_branch.py (+80/-58)
lib/lp/code/interfaces/branch.py (+5/-17)
lib/lp/code/model/branch.py (+14/-32)
lib/lp/code/model/tests/test_branch.py (+36/-96)
lp:~wgrant/launchpad/branch-type-policy-db
- Robert Collins (community): Approve
- Stuart Bishop: Pending (db) requested
-
Diff: 15 lines (+11/-0)1 file modifieddatabase/schema/patch-2209-26-0.sql (+11/-0)
lp:~wgrant/launchpad/branch-type-policy-model
- Brad Crittenden (community): Approve (code)
-
Diff: 563 lines (+315/-6)11 files modifiedlib/lp/code/model/branchnamespace.py (+64/-0)
lib/lp/code/model/tests/test_branchnamespace.py (+92/-3)
lib/lp/registry/browser/product.py (+6/-0)
lib/lp/registry/configure.zcml (+1/-1)
lib/lp/registry/enums.py (+61/-0)
lib/lp/registry/interfaces/product.py (+15/-0)
lib/lp/registry/interfaces/sharingservice.py (+7/-0)
lib/lp/registry/model/product.py (+9/-1)
lib/lp/registry/services/sharingservice.py (+19/-0)
lib/lp/registry/services/tests/test_sharingservice.py (+34/-1)
lib/lp/services/features/flags.py (+7/-0)
lp:~sinzui/launchpad/entitle-branch-sharing
- William Grant: Approve (code)
-
Diff: 473 lines (+27/-99)13 files modifiedlib/lp/bugs/browser/tests/test_bugs.py (+2/-6)
lib/lp/bugs/browser/tests/test_bugtarget_filebug.py (+4/-10)
lib/lp/bugs/mail/tests/test_handler.py (+2/-4)
lib/lp/bugs/tests/test_bugs_webservice.py (+1/-5)
lib/lp/code/browser/tests/test_branch.py (+4/-8)
lib/lp/code/browser/tests/test_branchlisting.py (+3/-3)
lib/lp/code/model/tests/test_branch.py (+4/-8)
lib/lp/code/model/tests/test_branchnamespace.py (+1/-4)
lib/lp/registry/model/product.py (+0/-8)
lib/lp/registry/tests/test_product.py (+1/-4)
lib/lp/registry/tests/test_product_webservice.py (+2/-32)
lib/lp/soyuz/tests/test_archive.py (+3/-4)
lib/lp/testing/sampledata.py (+0/-3)
lp:~sinzui/launchpad/commercial-admin-sharing
- Ian Booth (community): Approve
- Diff: 0 lines
Revision history for this message
| Robert Collins (lifeless) wrote Re: only sysadmins can setup branch privacy policies | #1 |
| summary: |
- want an api and ui to set branch privacy policy + only sysadmins can setup branch privacy policies |
| description: | updated |
Revision history for this message
| Robert Collins (lifeless) wrote | #2 |
Revision history for this message
| Martin Pool (mbp) wrote Re: [Bug 750871] Re: only sysadmins can setup branch privacy policies | #3 |
| summary: |
- only sysadmins can setup branch privacy policies + only commercial admins can setup branch privacy policies |
Revision history for this message
| Francis J. Lacoste (flacoste) wrote | #4 |
| Changed in launchpad: | |
| importance: | Critical → High |
Revision history for this message
| Jonathan Lange (jml) wrote | #6 |
| tags: | added: entitlement |
| tags: | added: sharing |
Revision history for this message
| Launchpad QA Bot (lpqabot) wrote | #8 |
| Changed in launchpad: | |
| assignee: | nobody → William Grant (wgrant) |
| tags: | added: qa-needstesting |
| Changed in launchpad: | |
| status: | Triaged → In Progress |
| tags: |
added: qa-ok removed: qa-needstesting |
Revision history for this message
| Launchpad QA Bot (lpqabot) wrote | #9 |
| tags: |
added: qa-needstesting removed: qa-ok |
| Changed in launchpad: | |
| status: | In Progress → Fix Committed |
| tags: |
added: qa-ok removed: qa-needstesting |
| Changed in launchpad: | |
| status: | Fix Committed → In Progress |
Revision history for this message
| Launchpad QA Bot (lpqabot) wrote | #10 |
| tags: |
added: qa-needstesting removed: qa-ok |
| Changed in launchpad: | |
| status: | In Progress → Fix Committed |
| tags: |
added: qa-ok removed: qa-needstesting |
| Changed in launchpad: | |
| status: | Fix Committed → In Progress |
Revision history for this message
| Launchpad QA Bot (lpqabot) wrote | #11 |
| tags: |
added: qa-untestable removed: qa-ok |
| Changed in launchpad: | |
| status: | In Progress → Fix Committed |
| Changed in launchpad: | |
| status: | Fix Committed → In Progress |
Revision history for this message
| Launchpad QA Bot (lpqabot) wrote | #12 |
| tags: |
added: qa-needstesting removed: qa-untestable |
Revision history for this message
| William Grant (wgrant) wrote | #13 |
| tags: |
added: qa-ok removed: qa-needstesting |
Revision history for this message
| Curtis Hovey (sinzui) wrote | #14 |
Revision history for this message
| William Grant (wgrant) wrote | #15 |
Revision history for this message
| Launchpad QA Bot (lpqabot) wrote | #16 |
| tags: |
added: qa-needstesting removed: qa-ok |
| Changed in launchpad: | |
| status: | In Progress → Fix Committed |
| tags: |
added: qa-ok removed: qa-needstesting |
| Changed in launchpad: | |
| status: | Fix Committed → Fix Released |
To post a comment you must log in.
I'm not sure that an API is helpful here, because the topic is complex and web pages are pretty good at explaining things.