only commercial admins can setup branch privacy policies

Reported by Martin Pool on 2011-04-05
10
This bug affects 2 people
Affects Status Importance Assigned to Milestone
Launchpad itself
High
William Grant

Bug Description

Projects have a branch privacy policy that says whether branches are public or private by default and whether they can be public or private. (I think.) At the moment this can only be changed by losas. It would be better if there was a ui and api for allowing project owners to read this and change it. There are some business rules about who is entitled to set particular values.

This causes a lot of latency for new users and a fair amount of work for feedback@, commercial@ and losas, on which grounds Robert says this can probably be critical.

I'm not sure that an API is helpful here, because the topic is complex and web pages are pretty good at explaining things.

summary: - want an api and ui to set branch privacy policy
+ only sysadmins can setup branch privacy policies
description: updated
Robert Collins (lifeless) wrote :

I've suggested this be critical on the basis that:
 - money is involved
 - losas are flat out and we would like them to only be asked to do actually sensitive things.

On 5 April 2011 10:19, Robert Collins <email address hidden> wrote:
> I'm not sure that an API is helpful here, because the topic is complex
> and web pages are pretty good at explaining things.

I agree actually. We mostly need an api for making particular new or
existing branches private.

Curtis Hovey (sinzui) on 2011-04-05
summary: - only sysadmins can setup branch privacy policies
+ only commercial admins can setup branch privacy policies
Francis J. Lacoste (flacoste) wrote :

Downgrading to High as this isn't worthy of Critical escalation.

Changed in launchpad:
importance: Critical → High
Robert Collins (lifeless) wrote :

I believe disclosure will be removing branch access policies (or reframing them) and will probably fix this as a side effect.

tags: added: disclosure
Jonathan Lange (jml) wrote :

This bug seems to contradict bug 290655.

Curtis Hovey (sinzui) wrote :

Thank you for finding that bug jml. This bug is about team/user branch policies. bug 290655 is about changing branch visibility. Both bugs will be fixed in a few weeks.

tags: added: branches teams
Curtis Hovey (sinzui) on 2012-06-26
tags: added: entitlement
Curtis Hovey (sinzui) on 2012-06-26
tags: added: sharing
Launchpad QA Bot (lpqabot) wrote :
Changed in launchpad:
assignee: nobody → William Grant (wgrant)
tags: added: qa-needstesting
Changed in launchpad:
status: Triaged → In Progress
William Grant (wgrant) on 2012-07-12
tags: added: qa-ok
removed: qa-needstesting
Launchpad QA Bot (lpqabot) wrote :
tags: added: qa-needstesting
removed: qa-ok
Changed in launchpad:
status: In Progress → Fix Committed
William Grant (wgrant) on 2012-07-13
tags: added: qa-ok
removed: qa-needstesting
Changed in launchpad:
status: Fix Committed → In Progress
Launchpad QA Bot (lpqabot) wrote :
tags: added: qa-needstesting
removed: qa-ok
Changed in launchpad:
status: In Progress → Fix Committed
William Grant (wgrant) on 2012-07-15
tags: added: qa-ok
removed: qa-needstesting
Changed in launchpad:
status: Fix Committed → In Progress
Launchpad QA Bot (lpqabot) wrote :

Fixed in db-stable r11767 (http://bazaar.launchpad.net/~launchpad-pqm/launchpad/db-stable/revision/11767) by a commit, but not testable.

tags: added: qa-untestable
removed: qa-ok
Changed in launchpad:
status: In Progress → Fix Committed
William Grant (wgrant) on 2012-07-16
Changed in launchpad:
status: Fix Committed → In Progress
Launchpad QA Bot (lpqabot) wrote :
tags: added: qa-needstesting
removed: qa-untestable
William Grant (wgrant) wrote :

Both BVP- and b_s_p-based sharing work fine on qastaging.

tags: added: qa-ok
removed: qa-needstesting
Curtis Hovey (sinzui) wrote :

From what I have seen, using qastaging, setBranchSharingPolicy() is hard coded to require the role. I think we can just remove the guards to close this bug?

William Grant (wgrant) wrote :

Right, the plan is to remove the commercial-admin guards and open it up to anyone with launchpad.Edit. Probably once the code is done and we're ready to enter beta.

Launchpad QA Bot (lpqabot) wrote :
tags: added: qa-needstesting
removed: qa-ok
Changed in launchpad:
status: In Progress → Fix Committed
Curtis Hovey (sinzui) on 2012-08-24
tags: added: qa-ok
removed: qa-needstesting
Steve Kowalik (stevenk) on 2012-08-28
Changed in launchpad:
status: Fix Committed → Fix Released
To post a comment you must log in.
This report contains Public information  Edit
Everyone can see this information.

Other bug subscribers