Lp allows users to run bzr upgrade with broken version

[Curtis Hovey]

Bug 636930 is fixed, but not all users have the fixed version installed. It would be helpful to users to if the upgrade instructions explained which version is need. It would be ideal if Lp rejected bzr commands for broken versions. Eg, 2.2.0 is known to fail when running bzr upgrade.

jdahlin@dragon:~$ bzr upgrade lp:stoqlib
...
starting upgrade of bzr+ssh://bazaar.launchpad.net/%2Bbranch/stoqlib/
making backup of bzr+ssh://bazaar.launchpad.net/%2Bbranch/stoqlib/.bzr
  to bzr+ssh://bazaar.launchpad.net/%2Bbranch/stoqlib/backup.bzr.~2~
starting repository conversion
135476kB 0kB/s - checking repository format:Copying content:Fetching revisions:Inserting stream:Walking content 5480/5480
bzr: ERROR: exceptions.AttributeError: 'Inter1and2Helper' object has no attribute 'source_repo'ream:Walking content 5480/5480

Traceback (most recent call last):
  File "/usr/lib/python2.6/dist-packages/bzrlib/commands.py", line 911, in exception_to_return_code
    return the_callable(*args, **kwargs)
  File "/usr/lib/python2.6/dist-packages/bzrlib/commands.py", line 1111, in run_bzr
    ret = run(*run_argv)
  File "/usr/lib/python2.6/dist-packages/bzrlib/commands.py", line 689, in run_argv_aliases
    return self.run(**all_cmd_args)
  File "/usr/lib/python2.6/dist-packages/bzrlib/commands.py", line 704, in run
    return self._operation.run_simple(*args, **kwargs)
  File "/usr/lib/python2.6/dist-packages/bzrlib/cleanup.py", line 135, in run_simple
    self.cleanups, self.func, *args, **kwargs)
  File "/usr/lib/python2.6/dist-packages/bzrlib/cleanup.py", line 165, in _do_with_cleanups
    result = func(*args, **kwargs)
  File "/usr/lib/python2.6/dist-packages/bzrlib/builtins.py", line 3310, in run
    upgrade(url, format)
  File "/usr/lib/python2.6/dist-packages/bzrlib/upgrade.py", line 88, in upgrade
    Convert(url, format)
  File "/usr/lib/python2.6/dist-packages/bzrlib/upgrade.py", line 42, in __init__
    self.convert()
  File "/usr/lib/python2.6/dist-packages/bzrlib/upgrade.py", line 82, in convert
    self.bzrdir = converter.convert(self.bzrdir, None)
  File "/usr/lib/python2.6/dist-packages/bzrlib/bzrdir.py", line 3190, in convert
    converter.convert(repo, pb)
  File "/usr/lib/python2.6/dist-packages/bzrlib/repository.py", line 4135, in convert
    self.source_repo.copy_content_into(converted)
  File "/usr/lib/python2.6/dist-packages/bzrlib/repository.py", line 1586, in copy_content_into
    return InterRepository.get(self, destination).copy_content(revision_id)
  File "/usr/lib/python2.6/dist-packages/bzrlib/decorators.py", line 194, in write_locked
    result = unbound(self, *args, **kwargs)
  File "/usr/lib/python2.6/dist-packages/bzrlib/repository.py", line 3424, in copy_content
    self.target.fetch(self.source, revision_id=revision_id)
  File "/usr/lib/python2.6/dist-packages/bzrlib/repository.py", line 1741, in fetch
    find_ghosts=find_ghosts, fetch_spec=fetch_spec)
  File "/usr/lib/python2.6/dist-packages/bzrlib/decorators.py", line 194, in write_locked
    result = unbound(self, *args, **kwargs)
  File "/usr/lib/python2.6/dist-packages/bzrlib/repository.py", line 3449, in fetch
    find_ghosts=find_ghosts)
  File "/usr/lib/python2.6/dist-packages/bzrlib/fetch.py", line 73, in __init__
    self.__fetch()
  File "/usr/lib/python2.6/dist-packages/bzrlib/fetch.py", line 99, in __fetch
    self._fetch_everything_for_search(search)
  File "/usr/lib/python2.6/dist-packages/bzrlib/fetch.py", line 127, in _fetch_everything_for_search
    stream, from_format, [])
  File "/usr/lib/python2.6/dist-packages/bzrlib/repository.py", line 4288, in insert_stream
    is_resume)
  File "/usr/lib/python2.6/dist-packages/bzrlib/repository.py", line 4317, in _locked_insert_stream
    for substream_type, substream in stream:
  File "/usr/lib/python2.6/dist-packages/bzrlib/repository.py", line 4524, in get_stream
    for _ in self._generate_root_texts(revs):
  File "/usr/lib/python2.6/dist-packages/bzrlib/repository.py", line 4493, in _generate_root_texts
    self.from_repository).generate_root_texts(revs)
  File "/usr/lib/python2.6/dist-packages/bzrlib/fetch.py", line 249, in generate_root_texts
    graph = self.source_repo.get_known_graph_ancestry(revs)
AttributeError: 'Inter1and2Helper' object has no attribute 'source_repo'

bzr 2.2.0 on python 2.6.6 (Linux-2.6.35.4-2.pvops-x86_64-with-Ubuntu-10.10-maverick)
arguments: ['/usr/bin/bzr', 'upgrade', 'lp:stoqlib']
encoding: 'UTF-8', fsenc: 'UTF-8', lang: 'en_US.UTF-8'
plugins:
  bash_completion /usr/lib/python2.6/dist-packages/bzrlib/plugins/bash_completion [2.2.0]
  launchpad /usr/lib/python2.6/dist-packages/bzrlib/plugins/launchpad [2.2.0]
  netrc_credential_store /usr/lib/python2.6/dist-packages/bzrlib/plugins/netrc_credential_store [2.2.0]
  news_merge /usr/lib/python2.6/dist-packages/bzrlib/plugins/news_merge [2.2.0]